Repository navigation
Lite: Queries-tab comparisons read a window shifted by the server's UTC offset #4284
Description
Activity
Ruling for the fix lane:
- Every Queries-tab comparison call gets the UTC window its grid read. The slicer handlers pass
e.StartUtcande.EndUtc. The refresh and Compare-dropdown paths pass the window fromLocalDataService.GetQueriesTabWindowUtc, the same one the banner beside each call already uses. GetComparisonRangetakes the current UTC window and shifts it back. The Darling viewer's copy (ViewerServerTab.QueriesComparison.cs) already works this way. Yesterday is 1 day back, and Last week and Same day last week are 7 days back.- One behavior changes on purpose. After a slicer drag, the baseline is the dragged window shifted back, not the whole preset range. Both windows then cover the same span.
- The comparison banner's baseline times are checked after the change, because
ServerTimeHelper.FormatServerTimeexpects UTC. - Tests use one server east of UTC and one west of UTC. The preset, custom-range and slicer paths must give the comparison the grid's UTC window. The baseline must be that window shifted by 1 or 7 days. If any comparison call gets a server-local time, a source check fails.
The Darling viewer already passes UTC windows to its comparisons, so it needs no change.
🤖 Generated with Claude Code
- Every Queries-tab comparison call gets the UTC window its grid read. The slicer handlers pass
- added a commit that references this issue
on Sep 25, 2026 Closed by the watcher: delivered in PR #4302, merged to dev.
Found while fixing the same bug in #4279's new "Showing since" banner.
Lite stores
collection_timein UTC. The Queries tab's comparison reads compare their start and end times straight against it, with no offset conversion. They areGetQueryStatsComparisonAsyncand its procedure-stats and Query Store twins inLite/Services/LocalDataService.*.cs. But two callers pass them server-local times:On...SlicerChangedhandler inLite/Controls/ServerTab.Slicers.csconvertse.StartUtcande.EndUtcto server time (fromServer,toServer). It passes those toRefresh...ComparisonAsync. The grid read beside it converts them back to UTC throughGetTimeRange. The comparison does not.Lite/Controls/ServerTab.Refresh.csbuildscStartandcEndfrom the date pickers in server time and passes them to the same three comparison calls.GetComparisonRange()(Lite/Controls/ServerTab.Comparison.cs:59) builds the baseline the same way (lines 66-77).So on any server not on UTC, the comparison reads a window shifted by the server's UTC offset. After a slicer drag, the current window is shifted but the baseline, from a preset range, is not. With the default "Last N hours" range and no slicer drag, both windows are UTC and correct.
Fix: give the comparison calls the UTC window the grid read. #4279 added
LocalDataService.GetQueriesTabWindowUtcfor the banner, and the slicer's owne.StartUtcande.EndUtcare already UTC. MoveGetComparisonRange()onto UTC at the same time, so the current and baseline windows stay on one basis. Check the comparison banner's displayed times after the change.ServerTimeHelper.FormatServerTimeexpects UTC.The Darling viewer's Queries tab passes UTC windows to its comparisons.