Repository navigation
Carry operator lines below the darling-managed.conf include across a major PostgreSQL upgrade #4358
Description
Claude posting for Erik Darling
Today DarlingStoreUpgrade.CarryAutoConfAsync carries only postgresql.auto.conf across a major PostgreSQL upgrade.
Lines an operator adds below the darling-managed.conf include in postgresql.conf are not copied into the new cluster; they stay behind in the old data directory.
#4336's docs note this limitation and point operators at ALTER SYSTEM (postgresql.auto.conf) as the path that is carried today.
Proposed fix: during a major-version upgrade, also copy any lines found below the include line into the new cluster's postgresql.conf, logging each line it carries over.
Activity
Move the managed store's settings into one included file, darling-man…
erikdarlingdata commentedon Sep 26, 2026
Claude posting for Erik Darling.
#4336 is merged (6dbb22a), so
darling-managed.confand its include are on dev. This issue is the remaining part: carry the operator lines below the include into the new cluster after a major PostgreSQL upgrade, and log each one.postgresql.auto.confis already carried.Wire CarryOperatorConfLinesAsync into the major-upgrade path for #4358
Add pins for #4358's operator-conf-line carry: ordering, rejected-lin…
Carry an operator's postgresql.conf lines below the include across a …
erikdarlingdata commentedon Sep 26, 2026
Claude posting for Erik Darling.
#4405 is merged (bd8a266). After a major PostgreSQL upgrade, the operator lines below the
darling-managed.confinclude are carried into the new cluster, and each one is probed against the new binaries. A rejected line is logged as not carried, and it never fails the upgrade.The live upgrade test needs the previous and new runtimes, which only the nightly workflow provides. This issue stays open until that test passes there.
Upgrade-path tests read the preload line where the managed settings n…
erikdarlingdata commentedon Sep 27, 2026
Claude posting for Erik Darling.
Fixed by #4446. In nightly #475 (https://github.com/erikdarlingdata/PerformanceMonitor/actions/runs/36299850820, dev at 3f3f7cb), the gated test
ManagedConfUpgradePathTests.UpgradeInPlace_OperatorLineBelowInclude_CarriedAndApplied_NoManagedKeyDuplicated_Gatedpassed by name. It checks that an operator line below the darling-managed.conf include is carried across a major PostgreSQL upgrade and applied, and that no managed key is duplicated. That run's other gated failures are tracked separately. Closing.