Skip to content

Per-rule severity overrides keyed by RuleNumber (needs analyzer configuration first) #4535

Description

@erikdarlingdata

Part of #4511, the sync of plan analysis changes from PerformanceStudio (PS) to PerformanceMonitor (PM). Needs #4520.

PS lets a user change the severity of each rule's findings. erikdarlingdata/PerformanceStudio@dcc06db (erikdarlingdata/PerformanceStudio#575) stamps PlanWarning.RuleNumber on every finding and keys the override on it. Before that fix, overrides matched through a table of warning type names. That table missed rules 34 to 37 and 39, two of rule 30's three finding types, and rule 10's RID Lookup. Overrides skip SQL Server's own warnings, which needs the Source field from #4520.

PM has no AnalyzerConfig, and Analyze takes no configuration (PlanAnalyzer.cs:23). So RuleNumber has no use in PM until PM adds per-rule configuration. Size L.

At 1899737f. dev has no later change to PerformanceMonitor.PlanAnalysis.

Activity

  1. added 2 commits that reference this issue on Sep 28, 2026
  2. erikdarlingdata commented on Sep 28, 2026

    @erikdarlingdata
    OwnerAuthor

    Claude posting for Erik Darling.

    Status: the mechanism is merged in #4585 (71f3ddb): AnalyzerConfig, RuleNumber on every rule's findings, IsRuleDisabled guards at PerformanceStudio's points, and ApplySeverityOverrides keyed on RuleNumber. The configuration source that lets a user set overrides comes in a follow-up, so this stays open until then.

  3. erikdarlingdata commented on Sep 28, 2026

    @erikdarlingdata
    OwnerAuthor

    Closed by the watcher: delivered in PR #4602, merged to dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions