Skip to content

Lite and Viewer: grid and list row actions are double-click only, with no keyboard path in source #4693

Closed as not planned

Description

@erikdarlingdata

Found by the source accessibility audit (lane X, from source). Each grid or list below opens its detail or history through a MouseDoubleClick handler and nothing else. No KeyDown/Enter handler, InputBindings or command was found for any of them in source (context-menu duplicates of the same action were not checked). A keyboard or UI Automation user can select the row but cannot open it.

Lite

  • Lite/MainWindow.xaml:267 ServerListView (opens the server tab)
  • Lite/Controls/ServerTab.xaml:504 QueryStatsGrid, :806 ProcedureStatsGrid, :1013 QueryStoreGrid, :1726 BlockedProcessReportGrid, :1837 DeadlockGrid, :2527 CollectionHealthGrid
  • Lite/Controls/FinOpsTab.xaml:839 StorageGrowthDataGrid, :975 ObjectGrowthDetailGrid, :1068 IndexLockingDataGrid
  • Lite/Controls/AlertsHistoryTab.xaml:109 AlertsDataGrid (opens alert detail)
  • Lite/Windows/ManageCredentialProfilesDialog.xaml:26, Lite/Windows/ManageMuteRulesWindow.xaml:25, Lite/Windows/ManageServersWindow.xaml:47, Lite/Windows/SettingsWindow.xaml:788 (edit the row)

Darling Viewer

  • Darling/PerformanceMonitor.Darling.Viewer/MainWindow.xaml:439 ServerList
  • ViewerServerTab.xaml:2483 BlockedProcessReportGrid, :2596 DeadlockGrid, :3615 CollectionHealthGrid; ViewerServerTab.History.cs:47-50 (QueryStatsGrid, ProcedureStatsGrid, QueryStoreGrid, QueryStoreRegressionsGrid wired in code)
  • FinOpsTab.xaml:538, :558, :613; AlertsHistoryTab.xaml:113
  • ManageCredentialProfilesDialog.xaml:26, ManageServersWindow.xaml:48, MuteRulesWindow.xaml:35, NotificationRoutesWindow.xaml:36

Suggested fix

One shared behavior: an Enter (and Return) key handler on each of these grids that calls the same handler the double-click calls, plus an "Open" context-menu item where none exists. One attached behavior can cover all of them.

Activity

  1. added
    in-progressActively being worked by a local session or its agents (PR open or in flight)
    and removed
    in-progressActively being worked by a local session or its agents (PR open or in flight)
    on Sep 29, 2026
  2. erikdarlingdata commented on Sep 29, 2026

    @erikdarlingdata
    OwnerAuthor

    Claude posting for Erik Darling

    Closing: not planned. The accessibility sweep that produced this issue is dropped, and its code change (#4696) is being reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions