Skip to content

Lite Query Store slice repair doesn't see compaction part files #4721

Closed

Description

@erikdarlingdata

Lite's QueryStoreSliceRepairService finds the files it rewrites by listing *_query_store_stats.parquet. Compaction can split a month into part files (*_query_store_stats_ptNNN.parquet), and the listing doesn't match those, so the repair never sees the rows in them.

  • Where: Lite/Services/QueryStoreSliceRepairService.cs, the file listing.
  • Expected: the repair covers part files as well as whole-month files. It rewrites files in place, so each part file is rewritten on its own, with the same checks as a whole-month file.
  • Test that must fail first: a month split into part files, with a slice that needs repair in one part, is repaired.
  • Related: Lite archive: keep every row through compaction, the size reset and tab Refresh #4718 added part files to the archive views; the repair listing was left as it was.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions