You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Darling worker: no signal when the fleet gate skips slots, and Extended Events sessions left on removed servers #4732
Four smaller gaps in DarlingWorker, two of them optional. Line numbers are as of 1248a67. Related: #4710.
1. No signal when the fleet gate cannot keep the cadence
DarlingWorker.cs:483,491,2660,9617 and CollectorCadence.cs:30-31. Missed slots are skipped with one Info log line. There is no skipped-slot count, no queue-wait measure and no gate self-alert, so an operator cannot see it happen. Capacity at hundreds of servers is worked out by arithmetic, not measured.
Expected: a queue-wait or slots-skipped measure, plus a self-alert past a threshold. Measure with a synthetic fleet before changing the gate width. Do not scale the gate with the core count: its ceiling of 16 is tied to the store's 24-connection pool.
Test: a saturated gate records skipped slots and raises the self-alert.
2. Removing a server leaves its Extended Events sessions running on the target
DarlingWorker.cs:4586-4608,3500 and DarlingXeSessions.cs:294,383,480. The cost is bounded: each ring buffer is 4 MB.
Expected: an explicit command-line cleanup verb. The service does not drop the sessions itself when a server is removed. The session names are shared with Lite and with any other Darling service, and an unreachable server cannot be cleaned anyway.
Test: the verb's argument handling and exit codes, using the existing DarlingToolExitCode values.
3. Scheduling uses the wall clock (optional)
DarlingWorker.cs:9545,9609,3465,9291. A backward clock step pauses collection for as long as the step. Automatic clock steps are only seconds long. If this is fixed, clamp a due time that is more than one interval ahead back to now, as RecomputeNextDueAsync does. A monotonic scheduler is too big a change for this.
4. After a server's definition is edited, the run in flight finishes on the old connection string (optional)
DarlingWorker.cs:4622,9529. The cost is one run's rows and one re-baseline. If this is fixed, discard the runtime after the connect when the definitions no longer match.
Activity
Darling: register the Collection Falling Behind resolution alias and …
Lite: a backward clock step no longer pauses a collector or the colle…
Darling worker: a backward clock step no longer pauses the worker's o…
Lite: a backward clock step no longer pauses the background housekeep…
A backward clock step no longer holds off the MCP and web host restar…
Darling: --drop-xe-sessions also drops the opt-in long query completi…
Darling: the README pin in the drop-xe-sessions tests reads the file …
Darling: Collection Falling Behind counts only slots that came due wh…
Darling: the fleet gate stats docs say the recorded skips are counted…
Custom alert rules, failed-send retries and the archive reset retry n…
Custom alert clock-step pins read the source through the shared repo …
--drop-xe-sessions: the guidance says when to run it, what it stops, …
--drop-xe-sessions: a live test for the SQL Server drop, and the stor…
Darling: the first launch after a start no longer waits out a backwar…
Merge origin/fix/4732-worker-gate-signal into the clock-step first-la…
Lite: the mid-wait clock step test counts only the cycles after the s…
A failed 'still down' alert retries on time after a backward clock st…
--drop-xe-sessions: the SQL the live test runs is the SQL the product…
Alert cooldowns and re-fire windows hold a repeat for one window afte…
Lite: a clock step back during the wait between collection cycles run…
The binary-file note throttle keeps the Collectors assembly free of a…
Darling: --drop-xe-sessions drops the Extended Events sessions a remo…
PgTargetAnomalyTests: the analyze_server check tops up its series to …
PgReadBinaryFileAdvisory: the stamp-rule comment says the compiled as…
Skipped collection slots are counted and alerted on, a backward clock…