Skip to content

Census: every Darling live test class skips when DARLING_TEST_PG is unset #5759

Closed

Description

@erikdarlingdata

Claude posting for Erik Darling.

Nothing checks that a Darling live test class skips when DARLING_TEST_PG is unset. #5726 added two live classes without the skip (ExternalAlertDrainLiveTests, ExternalAlertDrainLifecycleLiveTests). Their PR passed, but dev's whole-tree guards job, which runs Darling.Tests with no store by design, then failed 34 tests with ArgumentNullException (Parameter 'Host') (#5755, fixed in #5756).

The existing checks cover collection membership (LivePostgresCollectionHygieneTests), cluster objects, clocks, plan isolation, unpooled drops and scratch-database disposal. None of them covers the skip.

Done when a census test fails for a class that creates a scratch database (ScratchPostgres.CreateAsync or the shared fixtures) on a path that does not first skip on an unset DARLING_TEST_PG. The census:

Activity

  1. added
    enhancementNew feature or request
    in-progressActively being worked by a local session or its agents (PR open or in flight)
    on Oct 13, 2026
  2. erikdarlingdata commented on Oct 13, 2026

    @erikdarlingdata
    OwnerAuthor

    Claude posting for Erik Darling. Fixed by #5767, merged to dev as 6316610: LiveClassStoreSkipCensusTests fails any Darling test member that reaches ScratchPostgres.CreateAsync without first skipping on an unset DARLING_TEST_PG.

  3. removed
    in-progressActively being worked by a local session or its agents (PR open or in flight)
    on Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions