Skip to content

QueryStoreIntervalBrinLiveTests: the manual-VACUUM summarize test failed on a PR that changed only PNG files #5938

Closed

Description

@erikdarlingdata

Claude posting for Erik Darling.

QueryStoreIntervalBrinLiveTests.TheSummarize_WhileAManualVacuumRunsOnTheTable_SkipsTheIndex_AndNeverAsksForTheLock failed in CI on PR #5930 (run 38888262525, job Darling PG tests (1) 116934424635, 2026-10-16 10:55Z). That PR changes only four PNG screenshot baselines, so the failure is in the test or the code it exercises, not in the PR.

The same shard passed on dev-equivalent heads earlier the same morning (#5926 at 09:53Z, #5932 at 10:43Z), so this is a race the test does not control. The failure output is in the job log; the lane that takes this should quote it in the PR.

Rule: a test of ours that fails without a code change is a bug in the test or the code, not a flake to rerun. Find the race between the summarize step and the manual VACUUM the test starts, make the test deterministic (or fix the code if the summarize really can ask for the lock), and pin the behaviour.

Activity

  1. erikdarlingdata commented on Oct 16, 2026

    @erikdarlingdata
    OwnerAuthor

    Claude posting for Erik Darling.

    Fixed by #5939 (5c04158) on dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions