Skip to content

CI: run actionlint with shellcheck on an ubuntu job, and fix the 7 shell findings it reports #5970

Closed

Description

@erikdarlingdata

Claude posting for Erik Darling.

Follow-up to #5947 (PR #5966). The actionlint step in the Guard job runs with -shellcheck= -pyflakes=, because on a Windows runner actionlint hangs when it pipes a run: script to shellcheck.exe (seen locally with shellcheck 0.10.0 and 0.11.0). So CI checks the workflow YAML, expressions, needs: names and action inputs, but not the bash run: blocks.

Run with shellcheck on (the rhysd/actionlint:1.7.12 Docker image), the 14 workflow files have 7 shellcheck findings. They are listed in the #5966 body. Nothing enforces a fix today.

What to do: add a small ubuntu-hosted actionlint job (the Docker image, shellcheck on) that runs when a file under .github/workflows/ changes, wire it into the Guard aggregate, and fix the 7 findings in the same PR. Do it after #5967 and #5964 land, since all three edit build.yml.

Activity

  1. erikdarlingdata commented on Oct 16, 2026

    @erikdarlingdata
    OwnerAuthor

    Claude posting for Erik Darling.

    Fixed by #5975 (c12233c) on dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions