You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Server names: display name and host name on requests, briefs and webhook tokens (#5632 Phase C C3) #5999
Claude posting for Erik Darling.
Part of #5632 (Phase C, wave 1).
What it does
Requests, briefs and the webhook token carry both display_name and host_name. They are read from the registry when served, so a rename shows on the next read. server_name keeps its meaning (the display name) for everyone who reads it today.
Decisions this slice carries (agreed by Erik on 2026-10-16)
D18 (A). "display_name and host_name on the request, the brief and the webhook token, read from the registry when served." B (stored at open) was rejected because it "goes stale on a rename." "server_name keeps its meaning."
Files to touch
Pointers re-checked on dev at c12233ce3.
PerformanceMonitor.Common/Investigations/InvestigationToolCore.cs:466-472 (RequestFields, server_name = r.ServerName at 471).
The registry is the servers table (Darling/PerformanceMonitor.Darling.Storage/PgMigrations.cs:4051-4060: server_name and display_name). Existing display-name read: MonitoredServerDisplayNameAsync at Darling/PerformanceMonitor.Darling.Service/Mcp/DarlingMcpAlertTools.cs:1206.
Darling/PerformanceMonitor.Darling.Storage/InvestigationRequestStore.cs:98 (the server_name the request is opened with), :169, :177, :257 (the reads that return it).
PerformanceMonitor.Common/Investigations/InvestigationBriefComposer.cs (the brief) and PerformanceMonitor.Common/Investigations/InvestigationWebhookToken.cs (Render, called from PerformanceMonitor.Notifications/InvestigationDispatchCore.cs:236 and :245).
Pointer fixed: the plan cited DarlingWorker.cs:14571 for the request's server name. That line is in the collector snapshot loop and has nothing to do with it; the open path runs through Darling/PerformanceMonitor.Darling.Service/InvestigationDispatcher.cs:164-168 into the store at InvestigationRequestStore.cs:98.
No migration (the plan says read when served). If a join is needed for the MCP and token reads, put it in the existing request reads.
Depends on
None.
Behaviour to pin
A renamed display name shows on the next read of an existing request.
The host name matches the registry.
server_name still returns the display name.
Tests
Behaviour pins only, one test per behaviour listed above. No census, roster or source-text test (the #5833 ruling in .github/REVIEW-TRAPS.md).
Activity
Review round 1 (#5999): instance_name replaces host_name, one registr…
Investigation requests, briefs and webhook tokens carry both server n…
erikdarlingdata commentedon Oct 16, 2026
Claude posting for Erik Darling.
Fixed by #6015 (e747360) on dev.