FinOps Server Inventory: decouple from sys.dm_os_sys_info; surface hardware gap (#1535)

[erikdarlingdata]

What

Follow-up to #1589 (which fixed the connectivity probe but explicitly left the FinOps inventory display queries coupled to sys.dm_os_sys_info). On Azure SQL DB that DMV needs VIEW DATABASE STATE; a monitoring login without it made the whole GetServerPropertiesLiveAsync query throw, so the FinOps Server Inventory grid dropped the server's entire row (edition, version, storage — everything) and only wrote an AppLogger.Error.

Fix (both Lite and the deprecated Full Dashboard)

• Each GetServerPropertiesLiveAsync is split into two pinned const queries:
  • InventoryQueryText — every permission-free fact (edition CASE, SERVERPROPERTY scalars, engine-edition-aware dynamic-SQL storage), hardware columns replaced by typed NULLs, no FROM sys.dm_os_sys_info. Succeeds for any connected login.
  • HardwareQueryText — SELECT cpu_count, physical_memory_kb/1024, sqlserver_start_time, socket_count, cores_per_socket FROM sys.dm_os_sys_info, in its own try/catch; overwrites the hardware fields on success, sets HardwareUnavailableReason on failure. The row still renders edition/version/storage.
  • The inventory reader is scoped closed before the hardware read opens (the connection has no MARS — the Decouple SQL edition detection from sys.dm_os_sys_info - Azure SQL DB mis-detected as on-prem (#1535) #1589 lesson).
• Dashboard inventory storage additionally stops hard-coding sys.master_files (absent on Azure SQL DB) — it now uses the same EngineEdition = 5 ? sys.database_files : sys.master_files branch Lite already had, so the Dashboard query is Azure-safe end to end (identical work, both apps).

Visibility

• A non-alarming amber "Hardware Note" column in both FinOps Server Inventory grids, shown (with full text on hover) only when hardware inventory was denied.
• Dashboard MCP get_server_properties returns hardware_unavailable_reason.
• README documents that VIEW DATABASE STATE is what enables the sys.dm_os_* hardware inventory on Azure SQL DB, and that edition/version/storage degrade gracefully without it.

Tests / verification

• New FinOpsInventoryQueryTests regression guard in each app pins the split (inventory carries no dm_os_sys_info + still carries SERVERPROPERTY('EngineEdition') + sys.database_files; hardware carries sys.dm_os_sys_info).
• Full solution builds clean (0 errors). Lite.Tests 1434/0, Dashboard.Tests 768/0 (re-run locally). No Darling code changed.

Advances the FinOps follow-up tracked in #1535.

🤖 Generated with Claude Code