Repository navigation
#2136: gate + reset the cadence-warn Settings box (nightly wiring-test catch) - #2142
Merged
Merged
Conversation
… catch) The AlertSettingsControlWiringTests source-scan caught what PR CI's fast path missed: AlertStoreJobCadenceWarnPercentBox was loaded from the store but absent from UpdateAlertControlStates (unchecking Alerts Enabled left it editable) and from RestoreAlertDefaultsButton_Click (Restore Defaults left a stale value). Both call sites added, matching its #2107 siblings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Reviewed. This is a clean, minimal fix — nothing to flag.
No inline comments needed. |
dphugo
pushed a commit
to dphugo/PerformanceMonitor
that referenced
this pull request
Aug 19, 2026
config_service.query_store_backfill_enabled (V58, default TRUE), read live each backfill cycle through the store-reload seam and transition- logged. Viewer: Settings checkbox beside plan capture, probe sentinel + V58 gate rung, and the control-plane migration carries the store's current value through so importing MCP settings can never flip an operator's switch. The parameter has NO default on the update path - every caller states it (the erikdarlingdata#2142 silent-reset class). Field driver: 2026-08-10 consolidation - a freshly restored catalog put the backfill into sustained 64MB drains against a cross-region 4-core production primary (ASYNC_NETWORK_IO dominated) with no stop that didn't also gut plan capture fleet-wide. Lite parity is deliberately deferred (its backfill shares the class but Lite has no global settings surface to hang the toggle on) - erikdarlingdata#2167 stays open for that half. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly's
AlertSettingsControlWiringTestssource-scan caughtAlertStoreJobCadenceWarnPercentBox(added in #2141) loaded but absent from bothUpdateAlertControlStates(unchecking Alerts Enabled left it editable) andRestoreAlertDefaultsButton_Click(Restore Defaults left a stale value). Both call sites added, matching its #2107 siblings — exactly the forgotten-call-site class that test exists to catch.The same nightly run also failed
TimescaleSupportTests.EndToEnd_DetectConvertAndDropChunksPurge_AgainstDevPostgreson a40P01deadlock between the retention purge'sdrop_chunksand a background job on the shared dev store (the DELETE fallback deadlocked too) — unrelated to #2140/#2141, flaky-shaped, will re-kick the nightly after this merges and file the test-hardening item separately.