Repository navigation
Describe what --harden-files actually verifies - #2373
Merged
Merged
Conversation
|
Reviewed. This is a docs-only CHANGELOG.md edit (1 line changed, no code) — verified the added text against the actual implementation rather than just proofreading:
No T-SQL, no Lite/Darling parity surface (this string only exists in CHANGELOG.md), nothing security- or perf-relevant to flag. No issues found — the new wording is accurate and reads well against the code it describes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
[Unreleased]#2352 entry promised "VERIFIES each one afterwards" but described only the readability half, and said nothing about which account it hardens FOR — which is exactly the part that turned out to matter (#2371, fixed in #2372).Docs only; no code. Fold-into-3.5.0 is still pending the soak.