Repository navigation
Retire the onboarding workarounds that four merged fixes made untrue - #2493
Merged
Merged
Conversation
The guide documented four things as gaps a tester had to work around. All four shipped, so the guide now teaches the workaround for a problem the product no longer has -- which is worse than having said nothing, because a tester who follows it concludes the feature is missing. - 1.1 said install-darling.ps1 does not check the runtimes. It refuses on a missing ASP.NET Core runtime and warns on a missing Desktop one; the asymmetry is worth stating, since only the first stops the service. - 2.3 said there is no one place to see your seat, so you learn it a surface at a time. There is a seat indicator on the main window now, with the reason for this connection in the tooltip. - 4.4 said a rejected request leaves no trace and must be diagnosed from the client. Refusals are logged with the gate that rejected them, which is the "token or CIDR?" question answered outright. - 3.5 and 4.3 said a lost token costs a regenerate and a re-onboard of every client. --print-web-token and --print-mcp-token reprint it, elevated and on the encrypting box, because the blob is LocalMachine-scoped. Part 6 loses those four entries. The restart-only one stays, because it is still true; it just notes that the service says so now. Quoted strings taken from the shipped source rather than the PR summaries: the indicator really renders "Seat: read-only", and the refusal line really begins "MCP refused a request from" for a 403. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Reviewed. This is a docs-only change ( Verified every claim against the cited source, not just the PR description:
Also checked that removing the four Part 6 entries didn't leave any dangling "see Part 6" cross-references elsewhere in the doc — it didn't. No issues found; this is an accurate and well-sourced update. Nice touch pulling the invented rate-limiting entry per the PR note rather than leaving an unverified claim in a section testers are told not to file against. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
docs/uat-onboarding.mdmerged (#2476) while the four #2479 fixes were still in flight. They have all landed, and the guide still documents the gaps as things a tester must work around.That is worse than having said nothing. A tester who follows a workaround for a problem that no longer exists concludes the feature is missing — and the guide is the first thing a new UAT user reads.
What changed
install-darling.ps1does not check for the runtimes--print-web-token/--print-mcp-token(#2487)Detail worth keeping
LocalMachine-scoped. They write a live token to stdout, and the guide says to treat that console accordingly.How the strings were checked
Taken from shipped source, not from the PR descriptions — the earlier round of this work had a message promising a log line nobody wrote.
ViewerSeatIndicator.cs:63-64→"Seat: read-only"/"Seat: read-write"DarlingHttpRefusalLog.cs:345template +DescribeOutcome(>= 400→"refused") +Describe(SourceCidr)→ the quoted 403 lineDarlingCliCommands.cs:247-248→ both verbs and their "run elevated; writes a LIVE token to stdout" caveatNote
One draft of this added a Part 6 entry about viewer reconnect rate limiting. I had not verified it and removed it — Part 6 is the list testers are told not to file against, so an invented entry there suppresses a real report.