Repository navigation
Point alert-settings MCP tools at the Darling Viewer for webhook/SMTP config - #2712
Merged
Merged
Conversation
… config get_alert_settings, update_alert_settings, and the class doc comment all said SMTP/webhook delivery credentials are "managed separately" with no pointer to where. The mechanism already fully works - the standalone Darling Viewer's Settings window writes it, connects to a remote store (not just localhost), and the running service hot-swaps the change in - it just wasn't discoverable from the MCP surface.
|
Reviewed. This is a doc-only change to XML doc comments and
No issues found. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2709.
get_alert_settings,update_alert_settings, and the class-level doc comment onDarlingMcpAlertToolsall said SMTP/webhook delivery credentials are "managed separately" with no pointer to what that means. As #2709 documents, the mechanism already fully works — the standalone Darling Viewer app's Settings window (Notifications section) writesconfig.config_notification, its Postgres connection isn't hardcoded to localhost so it can configure a remote headless box, and the running service hot-swaps the change in with no restart. It just wasn't discoverable from the MCP surface an operator (or an agent working on their behalf) would actually consult first.Change
Extended the two tool descriptions and the class doc comment with a one-clause pointer to the Viewer's Settings window and its remote-connection capability. No behavior change — descriptions only.
Scoped to just the MCP tool descriptions (the issue's option 1) since that's what the issue title names directly and is the highest-leverage single change; didn't touch
darling.exe --help(option 2) since every existing help line maps to a real implemented verb and this is a docs-only fix, or add a new doc file (option 3) since the pointer fits cleanly inline.Test plan
dotnet build(project + full solution) clean, 0 errors🤖 Generated with Claude Code