Compose partial-window notice: "1 day", not "1 days" - #2785
Merged
Merged
Conversation
Found dogfooding a Custom View against a one-day-old store: the partial-window
notice read "reaches back about 1 days, but the requested window starts 1 days
back" -- the count was interpolated with a hardcoded "days" plural. Pluralise on
the RENDERED number instead (heldDays formats whole, windowDays to one decimal),
so "1" is singular while "1.5" / "30" stay plural. Sibling notices already use the
"day(s)" convention; this one is a prose notice, so proper singular/plural reads
better than "1 day(s)".
Test builds a measured hourly floor at now-1d with a 2-day window so both arms
fire in one notice ("1 day" + "2 days back"); the existing plural assertions
(4 / 10 / 90 days) still pass.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NejjkZaVWuzkinutWa2gLc
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NejjkZaVWuzkinutWa2gLc
erikdarlingdata
enabled auto-merge
September 2, 2026 20:13
|
Reviewed. Small, well-scoped grammar fix confined to Darling'''s web-dashboard composer ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found dogfooding a Custom View against a one-day-old store. The composer's partial-window notice (the amber box on a panel whose window reaches past the stored data) read:
ComposeStoreAvailability.BuildRetentionNoticeinterpolated the day count with a hardcodeddaysplural ({heldDays:0} days/{windowDays:0.#} days back). Now it pluralises on the rendered number:"1"→day,"1.5"/"30"→days. The sibling MCP notices already use theday(s)convention; this one is a prose notice, so proper singular reads better.Verified by a test that builds a measured hourly floor at
now-1dwith a 2-day window, so one notice exercises both arms ("1 day" + "2 days back"); the existing plural assertions (4 / 10 / 90 days) still pass. 258/258 DarlingComposeTests green. Pure grammar change, no logic touched.🤖 Generated with Claude Code