Repository navigation
Part of #2874 - #2962
Merged
Merged
Part of #2874#2962
Conversation
|
Reviewed. This is a comment-only fix to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2874. The one inline review nit on #2959, which merged before the fix landed.
TheConfigVersionWatermark_AdvancesOnlyInsideTheReloadSuccessBranch's doc comment still described the pre-#2959 call shape — "must sit INSIDE the braces of theif (await ReloadFromStoreAsync(...))that guards it" — while the call site is nowvar appliedVersion = await ReloadFromStoreAsync(...); if (appliedVersion.HasValue) { … }. The regex the test actually runs was already correct; only the prose above it was stale, which is the kind of comment that misleads the next reader trying to work out what the test pins.Updated to the current shape, and the second paragraph records why the negative against the outer read exists: the version #2946 shipped stamped
configVersion.Value, this test froze that imprecision, and review is what caught it. Stating that in the pin is what stops the negative from looking like belt-and-braces and being dropped.Comment-only change to a test file. 120 tests, 0 failed. No
CHANGELOG.mdentry, per the standing rule that lanes do not write that file.