Part of #2936 - #2965
Merged
Merged
Part of #2936#2965
Conversation
The store-migrate block still called itself "the ONLY step of the collection loop's start that kills collection", which this change is precisely what makes false - the config load and the managed bootstrap are the other two. Attempts and IsRetryable still described themselves in terms of the store interaction alone, though all three sites now share them.
|
Reviewed. This is a comment-only PR (no code/logic changes), and I traced both claims against the current source:
No T-SQL touched, so the CONTRIBUTING.md T-SQL style rules don't apply here. No Lite counterpart exists for No changes requested. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2936. Comment-only. Two claims the widening in #2955 made false, which its own review caught after that PR had already merged, so they land here instead.
DarlingWorker.cs— the store-migrate block still said "This block is the ONLY step of the collection loop's start that kills collection." #2955 is precisely what makes that untrue: the config load and the managed-Postgres bootstrap are triaged the same way through the same predicate and reach the sameLogCritical+returnwhen the classifier declines or the budget runs out. A reader counting kill points from that sentence would find one instead of three.StartupFailureTriage.cs—AttemptsandIsRetryablestill described themselves in terms of "the collection loop's first store interaction" although all three sites now share them.Attemptsnow also states the part that is easy to get wrong: each site keeps its own stopwatch, so the count is per site and not a budget the three draw down together.No behaviour change;
git diffis comment text only. Verified: the full solution builds with 0 errors, and the 62 tests compiled from the realStartupFailureTriageTests.cs+FleetIdentifierScrubTests.csstay green.