Use the repo's <host> placeholder for a measurement location in four files - #3020
Conversation
|
Reviewed. This is a one-line, docs-only change to The change itself is good practice — replacing a real-looking monitored host name in a changelog entry with a placeholder avoids leaking fleet-internal naming into a public file, and the entry's substance (measurement, dates, window, finding) is untouched. One nit, left as an inline comment: the PR description claims No correctness, security, or performance concerns — this doesn't touch executable code. |
|
Reviewed. This PR is a documentation-only change (CHANGELOG.md, 1 line) — no SQL, no Lite/Darling app code, so the T-SQL style conventions and Lite/Darling parity checks don't apply here. One finding posted inline: the hostname scrub is incomplete. No other issues — the placeholder choice ( |
|
Reviewed. This is a docs/comment-only change (host-name redaction), no functional/SQL logic touched — no Lite/Darling parity concerns, no security surface, no perf impact. One correctness issue found and flagged inline in both The |
Four places named a specific monitored host as the location of a measurement. All four now use
<host>, the placeholder spelling this repo already uses.CHANGELOG.md(#2759 entry)PerformanceMonitor.Collectors/QueryStoreOpenIntervalState.cs:68RefreshEverydoc comment, describing that same #2759 findingPerformanceMonitor.Collectors/PlanCorrectionCollector.cs:151Lite.Tests/PlanCorrectionCollectorDefinitionTests.cs:190The two carrying a database qualifier use
<host>/<database>.No behaviour change — every edit is inside a comment or a changelog line. The measurements, dates, windows and findings all still read the same; only the location is now a placeholder.
<host>is the established spelling:Darling/README.md:148(http://<host>:5153),Darling/README.md:1151(psql -h <host>), andCHANGELOG.md:265. An earlier revision of this PR used<target-host>, which appeared nowhere else in the tree and would have introduced a second divergent spelling.Scope note
The first revision changed only the changelog line. Review pointed out that the same string was live in three source files on the base branch, which made the change a partial one — the identical token would have remained in shipped source, including the doc comment on the very setting the changelog entry is about. Widened rather than split, since splitting would have left the observable half in place while presenting the work as done.
One other hostname-shaped token elsewhere in the changelog carries an allowlisted Greek-letter slug: synthetic, and left alone.