Use the placeholder convention for the host named in AlertEngine's poison-wait comment - #3043
Merged
Merged
Conversation
…ison-wait comment The comment explaining why poison-wait re-fire gates on a newer collection_time cited a concrete instance by name. Every other observation comment in the repo refers to targets through the placeholder convention, so this one now reads <monitor-host>. The reasoning it records is unchanged.
|
Reviewed. This is a comment-only change replacing a hardcoded hostname ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings one comment in
AlertEngineinto line with the placeholder convention the rest of the repo uses for targets.The comment above
_lastPoisonWaitCollectionTimeexplains why poison-wait re-fire gates on a newercollection_timeas well as on the cooldown: at fleet load the collector's delivered cadence can lag the cooldown, so the cooldown elapsing is not proof a fresh observation exists. It cited the instance the duplicate alerts were observed on by name. Every comparable observation comment refers to targets through a placeholder, so this one now reads<monitor-host>.The reasoning the comment records is unchanged — including the part worth keeping, that poison wait is deliberately not level-triggered like CPU, because a delta is one collector cycle's computation and reading it twice is the same event surfacing twice rather than two observations of a standing condition.
Comment-only: one line, no behaviour change, CRLF preserved (
--numstatreports 1/1, not a whole-file rewrite).CHANGELOG entry text
Nothing. A comment aligning with a naming convention is not a user-visible change and does not earn a line.