Repository navigation
Add the #3236 CHANGELOG entry (wave consolidation follow-up) - #3269
Merged
Merged
Conversation
The wave's fix PRs deliberately carried no CHANGELOG edits (parallel-agent hot-spot protocol); each agent reported its entry and this commit lands them together, byte-verified against origin/dev. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dqza1QNL4YCFS1MpzezERn
|
Reviewed. This is a clean, CHANGELOG-only change — no T-SQL, C#, or Lite/Darling code touched, so the usual correctness/parity/security/performance concerns don't apply here. Checked:
No blocking issues found. LGTM. |
pull Bot
pushed a commit
to ehtick/PerformanceMonitor
that referenced
this pull request
Sep 10, 2026
…erikdarlingdata#3236) Reverts PR erikdarlingdata#3268 and its CHANGELOG entry (erikdarlingdata#3269). Field review against the pgmon store showed the change is a net regression: EffectiveStaleThreshold takes the max over a server's collectors, so any enabled slow-cadence collector (these PG targets carry 9 hourly + 4 daily) pushes the per-server stale cutoff to tens of hours, while ClassifyFreshness checks the flat 30-minute Offline band first. That leaves the amber Stale band unreachable on every real target: a server reads Fresh until 30 minutes fully dark, then jumps to Offline, so a multi-minute collection gap now shows green. The original erikdarlingdata#3236 signature was a true positive (a real coverage collapse during the nightly restart), not the false positive the fix assumed, because last_collection is MAX over all collectors and the ~70s collectors keep it current on a healthy server. Reopening erikdarlingdata#3236 to re-diagnose with fleet measurement in the loop. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dqza1QNL4YCFS1MpzezERn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the #3236 CHANGELOG entry (cadence-aware fleet staleness, PR #3268) via the wave's consolidation protocol - the code PR deliberately carried no CHANGELOG edit. Same byte-verified splice mechanics as #3266: entry atop [Unreleased] ### Fixed, [#3236]: reference in numeric order, census 3617 -> 3619 LF with zero lone endings, staged blob asserted equal to the computed one.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Dqza1QNL4YCFS1MpzezERn