Repository navigation
The PostgreSQL Add Server dialog hides the lone SQL-auth radio (follow-up to #3499) - #3513
Merged
Merged
Conversation
…w-up to #3499) On the PostgreSQL engine arm the auth-type picker collapsed to a single radio still labeled "SQL Server Authentication" - force-checked but left visible, so a PostgreSQL target showed a one-choice picker mislabeled for the wrong engine (caught driving the live .447 nightly). Hide SqlAuthRadio on the PG arm too: it stays force-checked, and UpdateAuthPanels keys the username/password panel on IsChecked rather than Visibility, so the credentials still render directly under the Authentication header - which is exactly the "rather than leaving the operator a picker with one choice" the handler's own comment already claimed. Going back to SQL Server restores the radio. Test renamed and extended to pin the SqlAuthRadio visibility line. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RzwoqcD62jKyp6tzsWpZLz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the Add Server dialog's PostgreSQL engine arm, the auth-type picker collapsed to a single radio still labeled "SQL Server Authentication" — force-checked but left visible, so a PostgreSQL target showed a one-choice picker mislabeled for the wrong engine.
Caught while driving the live
3.7.0-nightly.20260917.447build on DARLING01 (Add Server → PostgreSQL).Fix
Hide
SqlAuthRadioon the PG arm too. It stays force-checked, andUpdateAuthPanelskeys the username/password panel onIsChecked(notVisibility), so the credentials still render directly under the Authentication header — which is exactly the "rather than leaving the operator a picker with one choice" the handler's own comment already claimed. Switching back to SQL Server restores the radio; the force-check still guarantees no hidden radio can be the checked one.Tests
PostgresAddServerDialogTestsrenamed toThePostgresArm_HidesEveryAuthTypeRadio_AndForceChecksSqlAuthand extended to pin the newSqlAuthRadio.Visibilityline. Full class 30/30 green locally;Darling.Testsbuilds with 0 errors.No CHANGELOG entry: #3499 is unreleased (dev only, no tag), so this is a pre-ship correction of a not-yet-shipped feature, not a user-facing change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RzwoqcD62jKyp6tzsWpZLz