Repository navigation
The delta calculator's doc names the census that actually guards the still-naked delta-family list (#3540 follow-up) - #3600
Merged
Conversation
…the naked-family list (#3540 follow-up)
erikdarlingdata
enabled auto-merge (squash)
September 18, 2026 16:14
There was a problem hiding this comment.
LGTM — verified this is a comment-only 1-line fix correcting a stale class-name reference in CollectorDeltaCalculator.cs. Confirmed the new name (DeltaFamilyIntervalColumnTests) and the StillNaked census/test it points to actually exist in Lite.Tests/DeltaFamilyIntervalColumnTests.cs. No executable code, T-SQL, or Lite/Darling parity impact.
1 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One comment, corrected
#3595 (V127 / Lite v60, #3540) rewrote
CollectorDeltaCalculator's "every consumer maps 0 to NULL" claim so it names which delta families persistsample_interval_secondsand which four still do not, and pointed readers at "a delta-family census in Lite.Tests (SharedCollectorDefaultsPinTests)" as the guard that keeps the naked list shrinking deliberately. The census is real, but it lives inLite.Tests/DeltaFamilyIntervalColumnTests(StillNaked+EveryDeltaFamily_PersistsItsInterval_OrIsNamedAsStillNaked) - the pointer named the file I first planned to put it in. Comments here are how the next contributor navigates, so the class name is fixed to the one that actually fails when a seventh family ships naked.Raised as a non-blocking nit by the bot review on #3595; auto-merge had already fired, hence the follow-up rather than a push to that branch. Comment-only; no behaviour, no test changes. Builds with 0 warnings.
Which component(s) does this affect?
Checklist
dotnet build -c Debug)