Repository navigation
The saturation-chain pin moves with the wait family: #3683 made lane 3's commented saturation ↔ Lock-wait edges live and merged before its pin move landed, so dev's PgTargetSessionsTests asserts an edge-less chain that no longer exists — the pin now names the mesh (#3542 lane 5 follow-up) - #3686
Merged
Merged
Conversation
…he chain now meshes with the two Lock-wait keys in both directions (four AddEdge calls), the permissions fact and the v2 idle-in-transaction hook still carry no edge
This was referenced Sep 19, 2026
erikdarlingdata
added a commit
that referenced
this pull request
Sep 19, 2026
… PRs across the #3653, #3542 and #3691 waves, #3704, #3710, #3712 and #3735, spliced once (#3751) Sixty-five PRs merged to dev since #3672 (the first splice) across two seats - the coordinator's #3653 brains-review residue lanes and the wave-2 worker's #3542 / #3691 PostgreSQL-target engine lanes - and by rule none touched this file; each returned its entry to a buffer. This is the one splice. Text-only; one file; nothing outside ## [Unreleased] and the definition block moves. [Unreleased] gains a ### Changed between ### Added and ### Fixed (Keep-a-Changelog order) for the nine entries whose subject is a designed behaviour that now behaves differently - routing (#3712 confidence chooses the channel), gating (#3692 tempdb persistence, #3734 blocking/LRQ gates, #3724 peak-and-mean), the wire shape (#3719 one error envelope), the review guard's drift arm (#3673), lineage metadata (#3723) and two grading changes (#3693, #3747). Twenty-two new capabilities append to ### Added (the sixteen PostgreSQL-target fact families and rungs, CONFIG_CHANGED, the recurrence label, the V134/V135 columns, the review traps file, the measurement census); thirty-two defects append to ### Fixed. Order within each section is ascending PR number, as #3672 did. Every entry is one line and verbatim from its buffer (trailing whitespace only). Four PR pairs fold into one entry as the buffers wrote them (#3738+#3746, #3683+#3686, #3681+#3685, #3726+#3729); #3695 carries three entries. #3673 has no issue and cites none, like the file's ninety-six other ref-less entries. Five definitions added ([#3691], [#3704], [#3710], [#3712], [#3735]) at the end of the [Unreleased] run, which stays one ascending run (3517..3735). No archive touched; the split was not run. tools/changelog/changelog_archive.py verify: all PASS (1,483 bold entries, floor 1,329; 1,363 distinct refs resolve; 1,372 definitions; CRLF throughout; 409,263 bytes under the ceiling). Client-hygiene grep over the file: zero hits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Headline mechanism. Moves one pin that #3683 (the wait family, #3542 lane 5) falsified on purpose and that merged red on dev:
PgTargetSessionsTests.TheSaturationChain_AddsNoEdgeInV1_AndSaysWhyInTheFileasserted thatPgTargetRelationshipGraph.Saturation.cscarries noAddEdgeand thatPG_CONNECTION_SATURATIONhas no edges. Lane 5 wrote the saturation ↔ Lock-wait mesh into that file (fourAddEdgecalls, both directions, per the design's saturation → Lock chain and lane 3's own commented-out hook), so the pin's premise is gone.Root cause narrative. The pin move was pushed to #3683's branch (cb643cc) eleven minutes after CI first reported it — and five minutes after the coordinator had already squash-merged the PR at its first head (5971efc). The follow-up commit therefore never reached dev; this PR carries exactly that commit, cherry-picked onto current dev.
What the pin says now (
TheSaturationChain_MeshesWithTheLockWaitsOnly_AndThePermissionsFactHasNoEdge): saturation's edges are exactlyPG_WAIT_LOCKandPG_WAIT_LOCK_RELATION;PG_MONITORING_PERMISSIONSand the v2PG_IDLE_IN_TRANSACTIONstill have none; the file has fourAddEdgecalls in code; the v2 hook is still present as a comment and not as code; lane 3's "added no edge of its own, deliberately" paragraph still stands. The wait-side pins (predicates, both walks) arePgTargetWaitTests'.Blast radius. One test method in one test file. No product code.
Test plan
Executed here through the net10.0 harness with the merged lane-5 code (89/89 across the wait, sessions, collector-census, routing and posture files).
Darling.Testsbuilds with zero warnings. First CI execution is the Windows job.Which component(s) does this affect?
How was this tested?
Above. No production store or fleet server was read.
Checklist
dotnet build -c Debug)Follow-up to #3683 (partial for #3542, lane 5). CHANGELOG untouched.