Repository navigation
The get_pg_log_events live pin reads its family / min_severity refusals as the invalid envelope they are now, not the error word they wore (#3739 follow-up) - #3779
Merged
Conversation
…ls as the invalid envelope they are now, naming the parameter, rather than the error word they wore (#3739)
erikdarlingdata
enabled auto-merge (squash)
September 20, 2026 02:40
erikdarlingdata
disabled auto-merge
September 20, 2026 02:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3776 (#3739), which was hand-merged at 02:34Z while its
Darling PostgreSQL testsjob was still running; that job finished red two minutes later on ONE test, and dev inherits it until this lands.The one red
PgLogEventsPipelineTests.ThePipeline_StoresReadsFiltersAndDedupes_AgainstDevPostgrespinnedget_pg_log_events'family/min_severityrefusals as"status": "error"— a JsonAssert-style pin of the WORD, which the sentence-fragment sweep behind #3776 did not see (it searched the refusal sentences, and this pin quotes neither). Those two refusals are theinvalidenvelope since #3776 — that was the point: they wore the failure word and answered HTTP 500 for a typo — so the pin now asserts exactly that:IsRefusalEnvelopetrue,IsErrorEnvelopefalse (so the old word cannot come back under aContains),hints.parameternamingfamily/min_severity, and the sentence read back throughErrorMessageOf.What was checked
Every other
"status": "error"/status\":\"errorspelling in both test projects (two hits, both #3776's own recognizer tests and the parity pin's example envelope); every live call of the nine PostgreSQL tools whose refusals changed word, for a badlimit/query_id/queryid(none pinned). The wholeDarling.Testsrun on the PR was 11,675 tests with this single red; the class builds with 0 warnings here and is live-PostgreSQL (CI is its first execution — the same shape it had on #3776, now for the right word).Partial #3739 — the issue was delivered by #3776; this is its one CI-first pin caught up.