Repository navigation
Lane orders: a failure that dev's CI passes is the lane's own, because pin tests read the files it changed - #4027
Merged
Conversation
…e pin and census tests read the files it changed #4025's lane called CollectionLogDrainForensicsStoreTests pre-existing because it reproduced alone. It reproduced because the test counts DarlingWorker's fault arms and the lane had added one; dev's CI passed it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GdmA4ND1wLSqA91ax1m4xv
erikdarlingdata
enabled auto-merge (squash)
September 23, 2026 12:14
erikdarlingdata
deleted the
docs/lane-orders-pin-tests-read-your-files
branch
September 23, 2026 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only (
.claude/skills/lane-orders/SKILL.md).Why
#4025's lane called
CollectionLogDrainForensicsStoreTestspre-existing because it reproduced when run alone. It reproduced because the test countsDarlingWorker's early-return fault arms, and the lane had added one. Dev's CI passes the test, and #4025's CI failed it.What changes
The pre-existing rule gains a second check. A failure that survives a fresh database is compared against dev's latest CI run. If dev passes it, it's the lane's own, since pin and census tests read the source files the lane changed.
Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01GdmA4ND1wLSqA91ax1m4xv