Repository navigation
The non-UTC log refusal names the log, not deadlocks (#2993) - #4070
Merged
erikdarlingdata merged 1 commit intoSep 23, 2026
Merged
Conversation
DARLING01's PG18 target (log_timezone America/Los_Angeles) records this refusal on pg_log_events, and the message said "every timestamp in its deadlock reports" and "NOT 'no deadlocks were detected'". The one throw site is PgLogEntryAssembler, which both PgLogEventClassifier (pg_log_events) and PgDeadlockLogParser (pg_deadlocks) read through, so the text written for deadlocks in #3001 now shows on log-event rows too. The message now names the log and says it is NOT an empty log. It keeps the zone token, log_timezone, the CST example, the parameter-group note and the reload-without-restart note, and drops the dashes and the semicolon. Lite's pin moves to "this is NOT an empty log" and fails if "deadlock" comes back. The exception's doc comment and the worker's catch arm comment name both readers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ua31ugERL5DmhFVRtf6keQ
erikdarlingdata
marked this pull request as ready for review
September 23, 2026 20:42
erikdarlingdata
deleted the
feature/2993-log-zone-refusal-names-every-reader
branch
September 23, 2026 20:43
erikdarlingdata
added a commit
that referenced
this pull request
Sep 23, 2026
…ntries in their sections (#4080) Adds 42 entries and 42 link refs (#3992, #3995, #3996, #3998, #4001, #4002, #4003, #4007, #4010, #4011, #4013, #4015, #4020, #4022, #4025, #4029, #4030, #4031, #4036, #4038, #4039, #4040, #4044, #4047, #4048, #4049, #4050, #4051, #4055, #4061, #4063, #4064, #4065, #4066, #4067, #4068, #4069, #4070, #4071, #4073, #4074, #4078). Each PR's entry was buffered, and this lands every entry whose PR was merged on origin/dev when it ran. #3989 left 26 entries under bare 'Changed' and 'Fixed' lines above '### Added'. They move into '### Changed' and '### Fixed', below the new entries, and one blank line stays under [Unreleased]. Claude-Session: https://claude.ai/code/session_01Ua31ugERL5DmhFVRtf6keQ Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After today's deploy to DARLING01, the PG18 target's pg_log_events collector recorded this refusal, as it has done since 09-19. That target's
log_timezoneisAmerica/Los_Angeles:The refusal itself is correct. The words are not: this was a log events row, not a deadlock row.
PgLogEntryAssembleris the one place that throwsPgLogTimezoneUnsupportedException, and both pg_log_events (PgLogEventClassifier) and pg_deadlocks (PgDeadlockLogParser) read the log through it. The message was written for deadlocks in #3001.What changes
log_timezone = 'UTC'. It keeps the zone token, the setting name, the CST example, the parameter group for managed PostgreSQL, and the reload without a restart. The message follows the plain-English rules and has no dashes or semicolons.The CHANGELOG entry is in the buffer for the pre-release splice.
Test plan
PgDeadlockLogParserTests: 74 passed.PgLogEventsPipelineTests,RdsDeadlockIngestorTests,RdsLogEventIngestorTimezoneTests,PgDeadlockLogTimezoneTests: 66 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ua31ugERL5DmhFVRtf6keQ