Repository navigation
The module-filter dedup test in QueryStoreDedupReadTests runs again (#4057) - #4084
Merged
Merged
Conversation
…4057) TopQueries_ModuleFilterRunsAfterIntervalDedup had no [Fact] attribute, so xUnit never ran it and the Lite.Tests build warned xUnit1013. Adding the attribute makes it run. It passes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014nCo36doEcUWapnXbJvY7L
erikdarlingdata
enabled auto-merge (squash)
September 23, 2026 22:13
8 tasks done
erikdarlingdata
added a commit
that referenced
this pull request
Sep 24, 2026
* Add 48 buffered CHANGELOG entries in one splice Adds 48 entries and 48 link refs (#4057, #4077, #4079, #4081, #4082, #4083, #4084, #4085, #4086, #4087, #4088, #4089, #4090, #4091, #4092, #4093, #4095, #4096, #4099, #4100, #4101, #4103, #4105, #4106, #4107, #4108, #4109, #4110, #4111, #4113, #4114, #4115, #4116, #4117, #4118, #4119, #4120, #4121, #4122, #4123, #4124, #4125, #4126, #4127, #4131, #4133, #4136, #4141). Each PR's entry was buffered, and this lands every entry whose PR was merged on origin/dev when it ran. Entries found under a bare section line (none unless the old script ran again) move into the matching ### section, below the new entries. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QQh8LczP1HGLXQYAx4oTZC * Changelog splice: add #4137's entry, which merged before the splice but was missed #4137 (pg_plan_capture reads csvlog) merged at 05:57Z with a CHANGELOG entry section in its body. It was neither spliced nor listed as needing no entry. Its entry goes under Fixed, right after #4136's, and #4136's last sentence now points to it instead of saying plan capture is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NUU29PuGg9TUFBsACgZg2K --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#4057 added the test
TopQueries_ModuleFilterRunsAfterIntervalDeduptoLite.Tests/QueryStoreDedupReadTests.cs. The test had no[Fact]attribute. Because of that, xUnit never ran it, and the Lite.Tests build gave warning xUnit1013.What changes
One line: the test now has
[Fact]. No product code changes.Test plan
dotnet build Lite.Tests/Lite.Tests.csproj -c Debug: build succeeded, 0 warnings. Before this change, the build gave 1 warning (xUnit1013).Lite.Tests.exe -method "*TopQueries_ModuleFilterRunsAfterIntervalDedup*": Total 1, Failed 0.Lite.Tests.exe -class "*QueryStoreDedupReadTests*": Total 21, Failed 0.🤖 Generated with Claude Code
https://claude.ai/code/session_014nCo36doEcUWapnXbJvY7L