Repository navigation
Make two live tests independent of the extension and the wall clock (#3953) - #4389
Merged
Merged
Conversation
erikdarlingdata
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3953. Test-only; no product change and no CHANGELOG entry.
QueryStoreTopLiteralEndStraddleLiveTestsdepends on the raw table being a TimescaleDB hypertable: the gate's chunk-floor input, and its failure diagnostic, readtimescaledb_information. It did not enable TimescaleDB on its scratch database, so it passed only when the extension happened to be present, and otherwise failed with42P01. It now enables TimescaleDB and converts the hypertables explicitly, the way its sibling live tests do, asserts thatcollect.query_store_statsis a hypertable, and guards the diagnostic's catalog read withto_regclass.This PR also anchors
SharedBaselineCacheLiveTests.Live_TheNextAnalysisHour_AndAnInvalidation_Recomputeto midnight of its seeded day. The seeded hour is six hours before the run, so during the 05:00 UTC hour it fell on the previous day, and "the next hour" crossed midnight into a new day-grain cache key (#4248). The cache was correct; the test's clock arithmetic was not anchored.