Repository navigation
Open fresh connections after the upgrade test restarts its server - #4397
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only.
UpgradeInPlace_OldMajorStoreWithRealData_UpgradesAndKeepsEverything_Gatedfailed in the nightly run with "An existing connection was forcibly closed by the remote host". The failure was on the first statement after the test restarted its server.The PostgreSQL log shows no crash. The test's
oldConnectionstring came fromDarlingManagedPostgres.BuildConnectionString, which is pooled, andBuildOldStoreAsynchad already opened pooled connections to the same server. Afterpg_ctl stopandstart, Npgsql handed back a physical connection from the previous server lifetime.The three
oldConnectionsites in this test file (this test and its two same-shape siblings) now setPooling = false, as the file's other connection strings already do.No CHANGELOG entry: test-only.