Repository navigation
Warm the settings redactor's patterns before their first timed match (#4348) - #4408
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4348.
The settings redactor's patterns are built with
RegexOptions.Compiledand matched under a 100 ms timeout. A compiled pattern's match methods are JIT-compiled on first use. On a busy CI runner, that first-use cost could land inside the first timed match. A short, ordinary value was then masked whole, as if its match had timed out. This showed up once in CI on one of the redactor corpus tests.What changes
PgSettingRedactor's static constructor warms every pattern once, before any real call, on a placeholder sample that reaches each pattern's match step. A timeout during the warm-up is ignored.WarmedUprecords that the warm-up ran. Output is unchanged.Tests
Warmup_RanBeforeFirstRealCall_AndShortValueIsNotMaskedWhole: the warm-up ran before the first call returns, and a short value is redacted normally.WarmupSampleMatches: every warmed pattern actually matches the sample, so each one's match step runs during the warm-up.CHANGELOG entry
SECTION: Fixed
ENTRY:
REF:
[Warm the settings redactor's patterns before their first timed match (#4348) #4408]: Warm the settings redactor's patterns before their first timed match (#4348) #4408