Repository navigation
Retry the DuckDB trim test when a parallel test holds the trim lock - #4415
Merged
Merged
Conversation
… false negative from lock contention (#4262)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only.
RunMemoryTrimCycle_AfterWideRead_ReducesProcessMemoryfailed on a CI run with DuckDB's reported memory unchanged across the trim (105906176 before and after).RunMemoryTrimCycletakes the process-wides_dbLockwithTryEnterWriteLock(0). It skips the cycle rather than block when another writer holds the lock, by design, so a live timer never stalls an archival. The lock is static across everyDuckDbInitializer, so a test running in parallel that holds it makes this test's trim skip silently. A standalone repro with no contention trimmed every time over 50 iterations.The test now retries the trim cycle, up to 20 times 50 ms apart, until usage is at or below the trim target. The contract is unchanged: usage must start above the 64 MB target and end at or below it. A trim that never releases memory still fails.
No CHANGELOG entry: test-only.