Plan analysis: a deeply nested plan no longer crashes the process that parses it (#4512) by erikdarlingdata · Pull Request #4551 · erikdarlingdata/PerformanceMonitor

ShowPlanParser: cap recursion depth and document size against untrusted plan XML (#4512)

erikdarlingdata

committed

435c224

ShowPlanParser: run recursion on a dedicated fixed-stack thread so the depth guard actually fires before the crash it prevents (#4512)

erikdarlingdata

committed

4e1d15f

Measure and document that the post-parse plan-analysis walks survive a 1 MB caller thread (#4512)

erikdarlingdata

committed

c5c0a24

Merge origin/dev into plan-sync/4512-parse-depth

erikdarlingdata

committed

b4d4aac

Say what the post-parse stack test pins in product terms (#4512)

erikdarlingdata

committed

3f21c21

Surface parse_error so a refused plan is no longer silent (#4551)

erikdarlingdata

committed

d56c26a

Make ScopedDescendants iterative and set a parse error on malformed plan XML (#4551)

erikdarlingdata

committed

60b65d8

Pin ScopedDescendants' iterative walk and the malformed-XML parse error (#4551)

erikdarlingdata

committed

56ee720

Merge remote-tracking branch 'origin/wip/4551-surface' into plan-sync/4512-parse-depth

scratch

committed

27c3bb6

Merge remote-tracking branch 'origin/dev' into plan-sync/4512-parse-depth

erikdarlingdata

committed

addf2ed

Skip analysis of a plan that failed to parse, and pin it on a partially parsed plan (#4512)

erikdarlingdata

committed

8bbc926

Keep the drill-downs' parse-error return: the parser's own warnings and missing indexes exist without analysis (#4512)

erikdarlingdata

committed

9ebf43d

Navigation Menu

Repository navigation

Plan analysis: a deeply nested plan no longer crashes the process that parses it (#4512) - #4551

Plan analysis: a deeply nested plan no longer crashes the process that parses it (#4512)#4551
erikdarlingdata merged 12 commits into
devfrom
plan-sync/4512-parse-depth

Commits on Sep 28, 2026

ShowPlanParser: cap recursion depth and document size against untrusted plan XML (#4512)

ShowPlanParser: run recursion on a dedicated fixed-stack thread so the depth guard actually fires before the crash it prevents (#4512)

Measure and document that the post-parse plan-analysis walks survive a 1 MB caller thread (#4512)

Merge origin/dev into plan-sync/4512-parse-depth

Say what the post-parse stack test pins in product terms (#4512)

Surface parse_error so a refused plan is no longer silent (#4551)

Make ScopedDescendants iterative and set a parse error on malformed plan XML (#4551)

Pin ScopedDescendants' iterative walk and the malformed-XML parse error (#4551)

Merge remote-tracking branch 'origin/wip/4551-surface' into plan-sync/4512-parse-depth

Merge remote-tracking branch 'origin/dev' into plan-sync/4512-parse-depth

Skip analysis of a plan that failed to parse, and pin it on a partially parsed plan (#4512)

Keep the drill-downs' parse-error return: the parser's own warnings and missing indexes exist without analysis (#4512)