Repository navigation
The upgrade wait test gives PowerShell 180 seconds to exit, the same limit the deploy tests use - #4911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
On #4896's CI run (commit
950bb7db, Darling PG tests (1) on Windows),DarlingUpgradeInstallTreeWaitTests.WaitDarlingInstallTreeClear_ReturnsEmptyAfterTheProcessExits_ButReturnsItWhenTheBoundIsTooShortfailed withpwsh did not exit within 60s running the extracted wait function.That shard ran 595 s, longer than usual, so the runner was loaded. #4896 doesn't touch the upgrade script or this test.Why
The test runs the extracted
Wait-DarlingInstallTreeClearfunction in Windows PowerShell 5.1 on Windows, with bounds of 10 s and 1 s. Its own limit for the PowerShell process to exit was 60 s. On a loaded Windows runner, PowerShell 5.1's start and module load alone can take most of that. The deploy tests hit the same thing, and #4866 raised their limit to 180 s (PowerShellExitLimit).What changed (tests only)
PowerShellExitLimit), the same as the deploy tests.Testing
Darling.Testsbuilds with 0 warnings and 0 errors.CHANGELOG
None: a test-only change.