Dependencies: SqlClient 7.1.1, Velopack 1.2.161 and two AWS SDK updates

[erikdarlingdata]

Supersedes #4943.

Why

Dependabot's #4943 moves five packages in Directory.Packages.props but leaves some packages.lock.json files on the old versions, so CI's locked-mode restore fails with NU1004 (Darling.Tests, Lite.Tests and Dashboard.Tests were never touched, and the two Installer files were only half updated). This branch is that PR's head, plus a merge of current dev, plus the missing lock-file regeneration, plus one csproj line taken back out.

What each bump brings:

• Microsoft.Data.SqlClient and Microsoft.Data.SqlClient.Extensions.Azure 7.1.0 to 7.1.1 (v7.1.1). Three fixes:
  • A zero-valued decimal or SqlDecimal parameter whose precision equals its scale threw ArgumentException.
  • Connection pool V2 handed out pooled connections with expired or nearly expired access tokens.
  • A connection open failed when ClearPool or ClearAllPools raced with an open already in progress.
• Velopack 1.2.158 to 1.2.161 (1.2.161). One fix that matters here: the Windows architecture check failed on systems without IsWow64Process2. The other two items in its notes are npm package updates for Velopack's own repository.
• AWSSDK.PI 4.0.100.14 to 4.0.100.15 and AWSSDK.RDS 4.0.105.3 to 4.0.106.1. Service model updates.

What changes

• Versions: the five lines in Directory.Packages.props, exactly as Bump the nuget-patch-and-minor group with 5 updates #4943 has them.

• Lock files: every packages.lock.json is now consistent with those versions. I ran dotnet restore PerformanceMonitor.sln --force-evaluate on top of Bump the nuget-patch-and-minor group with 5 updates #4943 and committed everything it rewrote.

  Lock file	In Bump the nuget-patch-and-minor group with 5 updates #4943	Here
  Lite, deprecated/Dashboard, deprecated/Installer.Core	updated	no further change
  deprecated/Installer, deprecated/Installer.Tests	half updated: Microsoft.Data.SqlClient.Extensions.Azure still 7.1.0	now 7.1.1
  Darling.Viewer	updated, with the Storage line below	Storage's direct SqlClient entry drops out again
  Darling.Tests, Lite.Tests, deprecated/Dashboard.Tests	not touched	regenerated

  Under deprecated/ only the five packages.lock.json files differ from dev (git diff --stat origin/dev...HEAD -- deprecated/ lists nothing else). Nothing else under deprecated/ changed.

• Other versions that move because of the bumps (no props line shows them): Microsoft.Data.SqlClient.Extensions.Abstractions and Microsoft.Data.SqlClient.Internal.Logging 7.1.0 to 7.1.1 in all nine lock files, and AWSSDK.Core 4.0.102.6 to 4.0.102.8 in Darling.Tests.

• SqlClient credential check from .github/dependabot.yml: Azure.Identity stays at 1.18.0, Azure.Core at 1.51.1 and Microsoft.Identity.Client at 4.84.2 in all nine lock files, and Azure.Identity.Broker is absent from all nine. The 7.1.1 notes list no change to credential options. I did not diff SqlClient's source for ExcludeBrokerCredential or the broker's packaging, which is the part of that guidance that has to be read by hand.

• Two Dashboard lock files carry more than the bumps. deprecated/Dashboard and deprecated/Dashboard.Tests still had project-reference versions of 3.8.0, and listed System.Diagnostics.EventLog and System.Security.Cryptography.ProtectedData. Regenerating moves the references to 3.9.0 and drops those two entries, which matches the other desktop lock files (Lite, Lite.Tests and Darling.Viewer list neither). The Dashboard copy of that change is already in Bump the nuget-patch-and-minor group with 5 updates #4943; the Dashboard.Tests copy comes from the restore.

• Storage csproj line removed. Bump the nuget-patch-and-minor group with 5 updates #4943 added <PackageReference Include="Microsoft.Data.SqlClient" /> to Darling/PerformanceMonitor.Darling.Storage/PerformanceMonitor.Darling.Storage.csproj. It is taken back out, so that file is identical to dev's. Storage already gets SqlClient through its project reference to PerformanceMonitor.PlanAnalysis, which references it directly, and central package management sets the version. Restore and build both pass without the line.

Test plan

• dotnet restore PerformanceMonitor.sln --force-evaluate: exit 0, rewrote six lock files (Darling.Tests, Darling.Viewer, Lite.Tests, Dashboard.Tests, Installer.Tests, Installer).
• The six locked-mode restores CI runs (Lite, Lite.Tests, Installer.Tests, Dashboard.Tests, Darling.Tests, Darling.Viewer, each with --locked-mode): all exit 0, no NU1004.
• dotnet build PerformanceMonitor.sln -c Debug: Build succeeded, 0 warnings, 0 errors, 19 projects. dev (467cd86, built the same way from a clean export) is also 0 warnings and 0 errors, so the count is the same.
• CI on this head (32d5301):
  • build (required): the six locked-mode restores, 0 warnings and 0 errors, Darling.Tests 19,892 total with 0 failed, 1,319 skipped (the live PostgreSQL tests, which skip without a PostgreSQL server) and 1 not run, Dashboard.Tests 838 with 0 failed, Installer.Tests 205 with 0 failed.
  • Lite tests shards 0 to 3: 1,608 + 1,920 + 1,935 + 1,712 = 7,175 tests, 0 failed, 0 skipped.
  • Darling PG tests shards 0 to 2, live PostgreSQL included: 6,518, 6,195 and 7,179 tests, 0 failed, 17 skipped, 1 not run. The required Darling PostgreSQL tests check passes.
  • Darling Linux build, Darling whole-tree guards, check-branches and description-drift pass.
• Darling.Tests.exe and Lite.Tests.exe on a local machine: not run. The CI runs above are the same suites on this exact commit.
• Nothing here exercises a real SqlClient connection to SQL Server, so the three 7.1.1 fixes themselves are not tested by this PR; it only shows that the new packages restore, build and pass the existing suites.