Repository navigation
DESKTOP: the Memory, Plan Cache and Session summary strips show when their snapshot was collected (part of #4966) - #5038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4966.
Why
A summary strip that draws the newest snapshot gave no sign of when that snapshot was taken. The Memory strip reads the newest snapshot ever, which can fall outside the chart window under it. The Plan Cache and Session strips read the newest point in the window. A reader couldn't tell stale from current.
What changes
HistoryTime.SnapshotCollected, which wraps the existingCollectionLocal). Empty value:--for Memory and Plan Cache,N/Afor Session.PlanCacheSummarySqlnow also returnsMAX(collection_time), andPlanCacheSummarycarries it asCollectionTime.SessionStatsSqlreturns the newest collection inside each bucket (latest_collection_time), andSessionStatsPoint.LatestCollectionTimecarries it. The strip shows the last bucket's value, the same collection Top Application and Top Host come from, not the bucket's grid time.Limits
Test plan
ViewerSnapshotStripCollectedTests: 5 cases (text, zone, empty marker, xaml elements, load wiring, SQL carries the time). Total 5, 0 failed.ViewerSnapshotStripCollectedLiveTests: seeds two Plan Cache collections and two Session collections inside ONE 1-minute bucket at off-minute seconds (+10 s, +50 s). Asserts the Plan Cache summary time, that the SessionLatestCollectionTimeis the newer collection, and that it differs from the bucket time. Also an empty window gives null. Total 1, 0 failed. RED: projectingbucket_startaslatest_collection_timefails it. Carries the#1776 own-storemarker.CHANGELOG
SECTION: Fixed
ENTRY: - Viewer summary strips show when their snapshot was collected ([#5038]) - The Memory, Plan Cache and Session Stats summary strips now show the time their snapshot was collected, in the display zone to the second, so a strip drawn from the newest snapshot no longer reads as current when it isn't.
REF: [#5038]: #5038