Repository navigation
LITE: the latch and spinlock trend charts say where their data starts (part of #4966) - #5086
Merged
Merged
Conversation
erikdarlingdata
marked this pull request as ready for review
October 4, 2026 17:00
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lite's Latches & Spinlocks tab draws a flat zero line when a trend's read is empty, so an empty stretch reads as "nothing happened". Each of the two trend charts now carries the same "Showing since" note Lite's grids carry. This is the Lite twin of the viewer's trend half of #5029.
What users see change
When the store's data begins inside the chosen window, a note above the latch chart and one above the spinlock chart reads "Showing since ", in the chart's own clock. When the window is covered, or is 90 minutes or less, nothing shows.
What changes
QueryWindowRelationgainsLatchStatsandSpinlockStats(at the end of the enum and of each switch arm), mapped tov_latch_stats/v_spinlock_stats, read by collector runs (latch_stats,spinlock_stats).ServerTab.xaml: a banner above each chart (grid rows renumbered).ServerTab.LatchSpinlock.cs: after the charts bind, each banner refreshes throughRefreshStoredWindowBannerAsync. A failed probe costs only its note.Test plan
DataStartBannerLatchSpinlockTests: per chart a notice test and a quiet-start test, plus a relation-map test and a wiring pin. RED on the relations-only commit: Total 7, Failed 7. GREEN with the fix: Total 7, Failed 0.comm -23against the known local list prints nothing. 0-warning--no-incrementalbuilds of both test projects.Limits
Both charts are zero-fill/empty-read charts, so both get the note; the snapshot grids are untouched.
CHANGELOG
SECTION: Fixed
ENTRY: - Lite's latch and spinlock trend charts say where their data starts ([#5086]) - when the store's data begins inside the chosen window, the charts show a "Showing since" note instead of a flat zero line.
REF: [#5086]: #5086