Repository navigation
Merge train 4843-19 (CI only; not for merge) - #5220
Closed
erikdarlingdata wants to merge 3 commits into
Closed
erikdarlingdata wants to merge 3 commits into
erikdarlingdata wants to merge 3 commits into
Conversation
Owner
Author
|
Superseded by train 19b. One member's own aliasing-hardening test fails in CI with the refusal message null - nothing refused - and that test is absent on dev, so it is new and attributable. The other two members ride 19b. Closing unmerged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge train, not for merge. CI runs once on dev plus the squash of each PR below, in this order. When it is green, each is squash-merged by itself in the same order, dev's tree is checked against this branch's, and this PR is closed unmerged.
Part of #4966, #5097 and #5158.
PRs in this train, in order
Train head
9de997ed4, treef33875cb2, base dev7aca8830a. No member moves the tools/list budget; the next train carries one that does, alone.A fourth pull request was excluded deliberately. It builds on the second member here and still carries that member's OLD commits, so its copy of one live test file differs from the version being landed. Each member lands as its own squash, so its squash would have quietly reverted the second member's fix, and the test would then fail on a later train looking like a fresh flake rather than a reversion. Its author is re-merging it against dev after this train lands and verifying that file byte-for-byte.
Local merged-tree checks: 1,803 tests, 0 build warnings; the store-upgrade class at 9 and the hygiene class, both matching dev. The repository-source scan over 403 classes reports no new failure. The live-store hygiene guard was emulated against this merged tree and reports 0 offenders — that guard cannot execute on macOS, so until a few hours ago a violation in it was visible only in CI, twenty minutes into a run.