Repository navigation
Merge train 4843-19b (CI only; not for merge) - #5223
Closed
erikdarlingdata wants to merge 2 commits into
Closed
erikdarlingdata wants to merge 2 commits into
erikdarlingdata wants to merge 2 commits into
Conversation
Owner
Author
|
Train landed. Its CI run was green with zero failing tests in every job - the second train tonight with no failures anywhere.
dev is now Two shards ran at or past the 15-minute watch line (PG(1) 15.8m, PG(2) 16.0m). Nothing failed, but a slower runner turns that into a timeout red rather than a test failure, so it is worth watching on the next few trains. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge train, not for merge. CI runs once on dev plus the squash of each PR below, in this order. When it is green, each is squash-merged by itself in the same order, dev's tree is checked against this branch's, and this PR is closed unmerged.
Part of #4966 and #5158.
PRs in this train, in order
Train head
fcd6654b7, tree5736e2e65, base dev7aca8830a. Neither member moves the tools/list budget.Two members were dropped from earlier builds of this train, each for a reason worth recording. One builds on the second member here and still carried that member's older commits, so its squash would have reverted a fix that the second member lands — its author is re-merging it and verifying the file byte-for-byte against dev. The other failed one of its own aliasing-hardening tests in CI with the refusal message null, meaning nothing was refused; that test is absent on dev, so it is new and attributable, and it had skipped on its author's Windows VM because that session cannot create a symbolic link, so a 23,640-passing run had never exercised it.
Local merged-tree checks: 1,793 tests, 0 build warnings; the store-upgrade class at 9 and the hygiene class, both matching dev at this commit. The repository-source scan over 402 classes reports no new failure, and the live-store hygiene guard — which cannot execute on macOS — was emulated against this merged tree and reports 0 offenders.