Repository navigation
lane-orders: the PostgreSQL rig recipe also creates the darling database, as CI does - #5292
Merged
Merged
Conversation
…ase, as CI does Step 5 of the rig recipe created only the suite and hand-run databases. CI's init step also creates darling, and the role-provisioning live tests grant CONNECT on it, so they fail with 3D000 on a rig built from the recipe. Step 5 now creates it with the same createdb call as CI and says why.
erikdarlingdata
added
the
merge-train
erikdarlingdata
marked this pull request as ready for review
October 5, 2026 22:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A rig built from this recipe has no
darlingdatabase. The role-provisioning live tests grant CONNECT on it, so they fail with3D000(database "darling" does not exist). In earlier runs on recipe-built rigs, five live test classes for the server and viewer failed this way.CI's init step creates the database. It runs
createdb.exefordarlingin.github/workflows/build.ymlaround line 1120, and again for each extra cluster around line 1178.CI also points
DARLING_TEST_PGatdarlingitself, while the recipe keeps a separate suite database. I left that as it is.What changes
Step 5 of the "PostgreSQL rig" recipe in
.claude/skills/lane-orders/SKILL.mdnow also createsdarling. It uses the samecreatedbcall as CI and gives the reason in one sentence.The suite database and the hand-run database stay as they were. Nothing else in the file changes, and the file keeps its CRLF line endings.
Test plan
Darling/Darling.TestsandLite.Testsforlane-ordersandSKILL.md. OnlyFleetIdentifierScrubTestsreads the skill, to scan it for fleet names.Darling/Darling.Tests/Darling.Tests.csprojwith 0 warnings and 0 errors.FleetIdentifierScrubTests: 3 tests, 0 failed, 0 skipped.