Repository navigation
The #5448 late-row live test passes from 00:00 to 04:00 UTC - #5494
Merged
Merged
Conversation
… day, so it passes from 00:00 to 04:00 UTC
erikdarlingdata
marked this pull request as ready for review
October 8, 2026 00:38
This was referenced Oct 8, 2026
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plan regression late-row live test failed every day from 00:00 to 04:00 UTC. Its seed built the window's days counted back from today. The window starts four hours before now, so in those hours its first day is yesterday minus 14 and was never built. The seed now counts the built days from the date of the window start. Only the test changes. The product already reads an unbuilt day live, by design.
The seed takes an optional fixed clock. The late-row test runs once on the real clock and again at 00:30, 03:59, 04:00 and 12:00 UTC on a fixed date. Every assertion is kept.
Why
CI failed shortly after midnight UTC. The late-row test failed at its first built-days assertion because the window's first day was missing from the built days.
What changes
Darling/Darling.Tests/PlanRegressionBuiltDaysFallbackLiveTests.cs:SeedAndBuildAsyncbuilds daysstart.Date - 14throughstart.Date - 3(wasnow.Date - 14throughnow.Date - 3). It takes an optionalutcNow. The late-row test body moved to a helper, with a Fact on the real clock and a Theory at the fixed clocks.PlanRegressionDaily: the read-shape, drill-down window-start, parity and trigger classes anchor the window on today itself or use constants. None pairs an hours-back window with a built-day range, so none share the defect. The drill-down reuse class builds no days.Test plan
PlanRegressionBuiltDaysFallbackLiveTests: Total 10, Failed 3 (real clock, 00:30, 03:59). The 04:00 and 12:00 cases passed.-trait Stage=Guard -failSkips: Total 1371, Failed 0.*Census*: Total 453, Failed 0 (1 skipped).*Ratchet*: Total 15, Failed 0.CHANGELOG: SECTION: None