Repository navigation
Release 3.10.0: changelog entries for the last fixes - #5557
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the changelog entries for the 3.10.0 PRs that merged after the first splice (#5548 covered everything through #5536). No issue. No dev to main PR, no tag, no release (Erik's ruling).
Why
The first splice stopped at #5536 (08:05Z). Eight more PRs merged afterwards with changelog text in the pending buffer, and one more (#5552) is still open.
What changes
Eight entries, each appended at the end of its section in
docs/changelog/3.10.md(full text) and in the 3.10.0 index ofCHANGELOG.md(title-only line). The 3.10.0 count goes from 257 to 265.[#N]ref links added for The module map refresh at service start and in the daily sweep reads from its watermark, not two days (#5519) #5528, A quiet server's job history and default trace watermark read tries the last week before its whole slice (#5515) #5532, Custom Views and custom alert rules scope server reads by server_id, not server name (#5525) #5537, Release checks: small fixes from the final walk of Lite and the Darling Viewer #5542, Query Store reads on the stored interval tables no longer miss an interval that began just before the table's floor (#5541) #5543, The startup sweeps stop a continuous aggregate's jobs before they drop it #5552, Lite's Job History reads only the selected time range, and tab loads read off the UI thread (#5457) #5553 inCHANGELOG.md.splitregenerated the archive's own link block.tools/changelog/archive-census.txt: the 3.10.0 row is now 265 entries with the new hash (written bycensus).How: I added the full entries to
docs/changelog/3.10.mdby script, put the ref links inCHANGELOG.md, and then ransplit. I did not put full entries into theCHANGELOG.md3.10.0 section.splittakes a version's prose from its existing archive. It refuses, or drops text, when both files carry prose.splitthen wrote the title-only index lines itself. Of the 12 filessplitwrites, only these three differ from dev.Entry text is the buffer text as written, with one wording fix from the seat in the #5553 Added entry ("and so does the log" in place of a stray ",."). Entries #5528, #5532, #5537, #5543 and #5552 use
([#N]). textrather than([#N]) - text, as do 14 existing 3.10 entries. I left those as they are.#5552's entry comes from the h3 file. Its REF line cited #5551, which no existing 3.10 entry does. So only the
[#5552]ref link was added.#5552 is not merged yet. Its entry is here, and its PR must merge before this one.
Proof of the entry lines
Script (worktree scratch, not committed) took the (section, line) set from the buffer and the h3 file, and compared with what the files gained.
docs/changelog/3.10.mdgained 8 entry lines, lost 0. Sorted-line SHA-256ada738f0ddb0579deb20de78f8af595aad9e2f3b003971937be0c253e60512da, identical to the SHA of the 8 expected lines (the buffer lines with the seat's one-sentence fix applied to the Lite's Job History reads only the selected time range, and tab loads read off the UI thread (#5457) #5553 Added entry).CHANGELOG.mdgained 8 index lines (plus 7 ref links), lost 0. Sorted-line SHA-25626683e3f0976182caa1aadba1fd9da5e2f8cfb9a83b6d201663009645b2a33d2, identical to the SHA of the title-only form of the 8 archive lines.Accounting: every PR merged after 08:06Z
## NoneEvery merged PR in the fresh list (10 of them: 5553, 5550, 5548, 5546, 5543, 5542, 5540, 5537, 5532, 5528) has a record. No PR is missing one.
Test plan
changelog_archive.py split(twice, second run idempotent: "wrote 12 files"),census(wrotearchive-census.txt).changelog_archive.py verify: every check PASS. The last line is "PASS ... 3.9.0: 760 entries ... matches", and 3.10.md's "274 distinct" refs resolve.changelog_archive.py roundtrip: "PROSE INTACT every version 3653e8d held is byte-identical in prose, and every link definition still resolves".-trait Stage=Guard -failSkipson Darling.Tests: Total 1400, Failed 0.For the seat to check