Repository navigation
Train: #5833 triage slices 1-6 (CI vehicle) - #5843
Closed
erikdarlingdata wants to merge 36 commits into
Closed
erikdarlingdata wants to merge 36 commits into
erikdarlingdata wants to merge 36 commits into
Conversation
StoreApplicationNameCensusTests, TsqlConventionGuardTests, Viewer4627EdgeCallerTests, ViewerCollectorCoverageTests and WpfExitSwitchPinTests assert how code is written, not what it does. Drops the one doc cref that named the deleted census.
…les (#5833) Removes 25 test methods that pin a call at a line, a SQL or XAML fragment, a literal's location, a CI filter line or a stale allow-list entry, and the five private helpers only they used. The behavior and wiring tests in each file stay.
CommandDeadlineScannerAdoptionTests and CommentFilterAdoptionTests are rosters of which test pins use which helper; CollectionLogWebRowPreservesFullTextPinTests pins one call's argument text. None fails on a product defect.
Deletes the methods that assert a call's text, a signature, a SQL fragment, a description's wording or a roster, and the private helpers only they used. Censuses that fail on a real defect (a missing deadline, a leaked statement, an alert past the master switch, a Lite/Darling drift) stay.
…helpers (slice 3, #5833)
Censuses and pins on doc wording, SQL fragments, constants, grid column order, trait rosters and coverage allow-lists. Part of #5833.
…budget ratchet files (#5833 slice 2)
…ovenancePinTests (#5833)
Three doc crefs in test files and two in DarlingCloudIdentityProbe named deleted tests; CrossAppGuardCiGateTests exempted four Lite.Tests reads that only the deleted CommentFilterAdoptionTests and NeitherFixHasALiteTwinToDriftFrom made.
QueryStoreClutterTests read the deleted Darling-only roster for a comment's wording; three doc comments named removed tests by cref. Part of #5833.
# Conflicts: # Lite.Tests/CrossAppMcpToolInventoryPinTests.cs
… census and keep LockedModeRestoreCoverageTests on the LF roster (#5833 slice 2)
McpToolsListBudgetTests.cs: the slice removed the tools/list byte ratchet, so dev's TotalCeilingBytes raise (#5819) goes with it; the served-shape checks stay.
TsqlConventionGuardTests.cs: deleted by the slice, modified on dev by #5819 (five walker exemption entries). The deletion stands.
CommentFilterAdoptionTests.cs: deleted by slice 1, trimmed by slice 2 (its DocCommentHygieneTests entry). The deletion stands.
CommentFilterAdoptionTests.cs: deleted by slice 1, trimmed by slice 3 (its RefreshCeilingProvenancePinTests entry and census summary). The deletion stands. RepoFileAdoptionTests.cs: deleted by slice 3, trimmed by slice 2 (DocCommentHygieneTests entry, LF roster). The deletion stands.
erikdarlingdata
marked this pull request as ready for review
October 15, 2026 04:59
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude posting for Erik Darling.
CI vehicle for #5833's six triage slices. The coordinator lands the members with train-land.sh; this PR itself is never merged.
Manifest (landing order)
fix/5833-triage-1f9b11c139fix/5833-triage-27bd73a6d7fix/5833-triage-347db1a9eefix/5833-triage-4eb243a2f3fix/5833-triage-55b916e756fix/5833-triage-6ebf76b619train/5833-slices= origin/dev (a57197581) plus six--no-ffmerges of the members above, in landing order; every merge is clean, because each conflict was resolved inside the member that meets it. Every member moved by merge commits only (no rebase, no force push).Conflicts and resolutions
With dev (each member got
git merge origin/dev; 1, 3, 5 and 6 merged clean):Darling/Darling.Tests/McpToolsListBudgetTests.cs: the slice removed the tools/list byte ratchet (TotalCeilingBytesand its change log); dev's Alerts hand a Level 1 investigation to your own agent (#5632 Phase A) #5819 raised that constant 198_998 -> 202_044. The constant is gone in the slice, so dev's hunk goes. The served-shape checks (ConvertedHeadCap,ConvertedParameterCapand their facts) stand.Darling/Darling.Tests/TsqlConventionGuardTests.cs: deleted by the slice, modified on dev by Alerts hand a Level 1 investigation to your own agent (#5632 Phase A) #5819 (five walker exemption entries). The deletion stands.Member to member:
Darling/Darling.Tests/CommentFilterAdoptionTests.cs: slice 1 deleted the file, slice 2 trimmed itsDocCommentHygieneTestsentry. The deletion stands. Resolved in slice 2 by mergingfix/5833-triage-1.CommentFilterAdoptionTests.cs(deleted by slice 1, trimmed by slice 3: theRefreshCeilingProvenancePinTestsentry and the census summary) andDarling/Darling.Tests/RepoFileAdoptionTests.cs(deleted by slice 3, trimmed by slice 2: theDocCommentHygieneTestsentry and the LF roster). Both deletions stand. Resolved in slice 3 by mergingfix/5833-triage-2(which already carries slice 1).Net train diff against dev: 212 files, +37 / -23,728; nothing under
deprecated/, no CHANGELOG.md edit.Gate (
bash .github/scripts/pre-push.shon the train tree)Guard-stage totals: Darling 4613 -> 4246, Lite 1281 -> 1151. The "before" side is dev's own Guard run on
a57197581(run 38682870179: Darling Total 4613, Failed 2; Lite Total 1281, Failed 0); the brief's 4601 predates #5819 and #5830. The coordinator ruled to push with the dev-inherited RED below documented; a separate lane fixes it on dev.The two Guard failures are dev's, not the slices':
EffectiveReadWindowCensusTests.EveryToolWithAWindowArgument_NotesTheWindowItRanWithand.NoDarlingRead_CallsTheSharedWindowValidatorsDirectly_UnlessRostered, both namingget_investigation_reports(DarlingMcpInvestigationTools.cs:557calls the shared window validators directly). #5819 added that tool and #5830 (#5814) added the census; they landed back to back. Dev's own Build run 38682870179 ona57197581fails the same two tests in its Guard job (Darling Total 4613, Failed 2). No slice touches either file, so this train neither causes nor fixes them.Skipped counts in the class runs are live classes; no rig was brought up (CI's PostgreSQL jobs run them).
Not done
EffectiveReadWindowCensusTestsbreak (above) is not fixed here: it is in no member's files.DocCommentHygieneTests.FindRepoRootin several doc comments,TsqlConventionGuardTestsinCSharpMemberMap.cs) were left as they are: they are prose, no conflict produced them, and the gate does not flag them.