Skip to content

Train: #5833 triage slices 1-6 (CI vehicle) - #5843

Closed
erikdarlingdata wants to merge 36 commits into
devfrom
train/5833-slices
Closed

erikdarlingdata wants to merge 36 commits into
devfrom
train/5833-slices

Conversation

@erikdarlingdata

Copy link
Copy Markdown
Owner

Claude posting for Erik Darling.

CI vehicle for #5833's six triage slices. The coordinator lands the members with train-land.sh; this PR itself is never merged.

Manifest (landing order)

# Member PR Branch Head after this push
1 #5840 fix/5833-triage-1 f9b11c139
2 #5842 fix/5833-triage-2 7bd73a6d7
3 #5839 fix/5833-triage-3 47db1a9ee
4 #5837 fix/5833-triage-4 eb243a2f3
5 #5841 fix/5833-triage-5 5b916e756
6 #5838 fix/5833-triage-6 ebf76b619

train/5833-slices = origin/dev (a57197581) plus six --no-ff merges of the members above, in landing order; every merge is clean, because each conflict was resolved inside the member that meets it. Every member moved by merge commits only (no rebase, no force push).

Conflicts and resolutions

With dev (each member got git merge origin/dev; 1, 3, 5 and 6 merged clean):

Member to member:

Net train diff against dev: 212 files, +37 / -23,728; nothing under deprecated/, no CHANGELOG.md edit.

Gate (bash .github/scripts/pre-push.sh on the train tree)

Guard-stage totals: Darling 4613 -> 4246, Lite 1281 -> 1151. The "before" side is dev's own Guard run on a57197581 (run 38682870179: Darling Total 4613, Failed 2; Lite Total 1281, Failed 0); the brief's 4601 predates #5819 and #5830. The coordinator ruled to push with the dev-inherited RED below documented; a separate lane fixes it on dev.

  [guard-darling]    Darling.Tests  Total: 4246, Errors: 0, Failed: 2, Skipped: 0, Not Run: 0, Time: 54.108s
  [guard-lite]    Lite.Tests  Total: 1151, Errors: 0, Failed: 0, Skipped: 0, Not Run: 0, Time: 44.967s
classes: darling 266, lite 57
  [classes-darling]    Darling.Tests  Total: 2489, Errors: 0, Failed: 0, Skipped: 224, Not Run: 0, Time: 135.604s
  [classes-darling]    Darling.Tests  Total: 2607, Errors: 0, Failed: 0, Skipped: 82, Not Run: 0, Time: 25.294s
  [classes-lite]    Lite.Tests  Total: 849, Errors: 0, Failed: 0, Skipped: 0, Not Run: 0, Time: 60.900s
GATE RED: guard-darling

The two Guard failures are dev's, not the slices': EffectiveReadWindowCensusTests.EveryToolWithAWindowArgument_NotesTheWindowItRanWith and .NoDarlingRead_CallsTheSharedWindowValidatorsDirectly_UnlessRostered, both naming get_investigation_reports (DarlingMcpInvestigationTools.cs:557 calls the shared window validators directly). #5819 added that tool and #5830 (#5814) added the census; they landed back to back. Dev's own Build run 38682870179 on a57197581 fails the same two tests in its Guard job (Darling Total 4613, Failed 2). No slice touches either file, so this train neither causes nor fixes them.

Skipped counts in the class runs are live classes; no rig was brought up (CI's PostgreSQL jobs run them).

Not done

  • Dev's EffectiveReadWindowCensusTests break (above) is not fixed here: it is in no member's files.
  • The members' "Undecided" items are left to a later lane, as briefed.
  • Comments in surviving files that still name deleted classes (for example DocCommentHygieneTests.FindRepoRoot in several doc comments, TsqlConventionGuardTests in CSharpMemberMap.cs) were left as they are: they are prose, no conflict produced them, and the gate does not flag them.

StoreApplicationNameCensusTests, TsqlConventionGuardTests, Viewer4627EdgeCallerTests,
ViewerCollectorCoverageTests and WpfExitSwitchPinTests assert how code is written, not
what it does. Drops the one doc cref that named the deleted census.
…les (#5833)

Removes 25 test methods that pin a call at a line, a SQL or XAML fragment, a literal's
location, a CI filter line or a stale allow-list entry, and the five private helpers only
they used. The behavior and wiring tests in each file stay.
CommandDeadlineScannerAdoptionTests and CommentFilterAdoptionTests are rosters
of which test pins use which helper; CollectionLogWebRowPreservesFullTextPinTests
pins one call's argument text. None fails on a product defect.
Deletes the methods that assert a call's text, a signature, a SQL fragment,
a description's wording or a roster, and the private helpers only they used.
Censuses that fail on a real defect (a missing deadline, a leaked statement,
an alert past the master switch, a Lite/Darling drift) stay.
Censuses and pins on doc wording, SQL fragments, constants, grid column order, trait rosters and coverage allow-lists. Part of #5833.
…#5833 slice 5)

The behavior and defect checks in each file stay. Part of #5833.
Three doc crefs in test files and two in DarlingCloudIdentityProbe named
deleted tests; CrossAppGuardCiGateTests exempted four Lite.Tests reads that
only the deleted CommentFilterAdoptionTests and NeitherFixHasALiteTwinToDriftFrom made.
QueryStoreClutterTests read the deleted Darling-only roster for a comment's wording; three doc comments named removed tests by cref. Part of #5833.
# Conflicts:
#	Lite.Tests/CrossAppMcpToolInventoryPinTests.cs
… census and keep LockedModeRestoreCoverageTests on the LF roster (#5833 slice 2)
McpToolsListBudgetTests.cs: the slice removed the tools/list byte ratchet, so dev's TotalCeilingBytes raise (#5819) goes with it; the served-shape checks stay.
TsqlConventionGuardTests.cs: deleted by the slice, modified on dev by #5819 (five walker exemption entries). The deletion stands.
CommentFilterAdoptionTests.cs: deleted by slice 1, trimmed by slice 2 (its DocCommentHygieneTests entry). The deletion stands.
CommentFilterAdoptionTests.cs: deleted by slice 1, trimmed by slice 3 (its RefreshCeilingProvenancePinTests entry and census summary). The deletion stands.

RepoFileAdoptionTests.cs: deleted by slice 3, trimmed by slice 2 (DocCommentHygieneTests entry, LF roster). The deletion stands.
@erikdarlingdata erikdarlingdata added the merge-train In a merge train: its CI ran on the train PR label Oct 15, 2026
@erikdarlingdata
erikdarlingdata marked this pull request as ready for review October 15, 2026 04:59
@erikdarlingdata

Copy link
Copy Markdown
Owner Author

Claude posting for Erik Darling. Train run 38709286328 green on the combined tree; the six slices landed on dev one by one (#5840 #5842 #5839 #5837 #5841 #5838, TREE-OK). Closing unmerged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-train In a merge train: its CI ran on the train PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant