Skip to content

Remove the unused AvaloniaEdit.TextMate.Grammars package reference #545

Closed

Description

@erikdarlingdata

Found during the Avalonia 12 upgrade planning. PlanViewer.App.csproj references AvaloniaEdit.TextMate.Grammars 0.10.12.1, but no app code uses it: the package ships its own RegistryOptions/ThemeName under the AvaloniaEdit.TextMate.Grammars namespace, while every call site binds TextMateSharp.Grammars instead (QuerySessionControl.Editor.cs uses it via a using directive; PlanViewerControl.Schema.cs fully qualifies it). The two never collide because the AvaloniaEdit namespace is never imported. Removing the reference also drops Newtonsoft.Json 13.0.1 and TextMateSharp 1.0.23 from the resolved graph, which is why it was kept out of the migration PR (a runtime-graph change in a release meant to be nothing but the migration). Safe cleanup for a normal release.

Activity

  1. erikdarlingdata commented on Sep 22, 2026

    @erikdarlingdata
    OwnerAuthor

    Merged to dev in #552 — the package reference is gone, and Newtonsoft.Json left the resolved graph with it. Ships in the next release.

  2. added a commit that references this issue on Sep 24, 2026
    3dd4174
  3. added a commit that references this issue on Oct 1, 2026
    e4003f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions