Repository navigation
Correct the SignPath comments for action v3 - #570
Merged
Merged
Conversation
The v1.27.0 Release run did not sign. Action v3 sends requests to SignPath's new Pipeline Connector, which needs the SignPath GitHub App on the repository, and SignPath signs only the first 3 attempts of a run. The app is now installed. release.yml: note the app requirement and the 3-attempt limit above the signing step, and correct the timeout comment, which still said a failed signing leaves a published release. release-signing.yml: note that the Pipeline Connector reads this file only when the signing policy references it as a Pipeline Policy. Correct the reasons for leaving out build.disallow_reruns (the release is now created after signing) and branch_rulesets (main now has the "Protect main" ruleset). Comments only. Part of #569. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011ujjGZ64tzhVqkEBfaxe4o
|
Reviewed. This is a comment-only change to Spot-checked the factual claims in the new comments against the current repo state:
No correctness, security, or convention issues found. LGTM. |
This was referenced Sep 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.ymland in the SignPath policy file were out of date. They described the release flow from beforegh release createmoved after signing. They also did not mention the app requirement or the limit of 3 attempts for each run.Changes
.github/workflows/release.yml: Add a note above the "Sign Windows build" step. The note says that v3 needs the SignPath GitHub App, and that SignPath signs only the first 3 attempts of a run. Correct the timeout comment, because a failed signing no longer leaves a published release..signpath/policies/PerformanceStudio/release-signing.yml: Add a note from the SignPath changelog (Pipeline Connector 0.8.0, 2026-09-09). The Pipeline Connector reads this file only when the signing policy references it as a Pipeline Policy. Correct the reason for leaving outbuild.disallow_reruns, because the release is now created after signing. Correct the reason for leaving outbranch_rulesets, becausemainnow has the "Protect main" ruleset.Test Plan
git diffchanges comment lines only.Part of #569.
Generated with Claude Code
https://claude.ai/code/session_011ujjGZ64tzhVqkEBfaxe4o