Skip to content

short address check and dont allow self transfer - #3

Open
akash-bansal wants to merge 1 commit into
ethfinex:masterfrom
akash2504:bug_report
Open

akash-bansal wants to merge 1 commit into
ethfinex:masterfrom
akash2504:bug_report

Conversation

@akash-bansal

Copy link
Copy Markdown

No description provided.

@plutoegg

Copy link
Copy Markdown
Contributor

I don't see any reason to necessarily disallow self transfers?

@akash-bansal

Copy link
Copy Markdown
Author

In my opinion to allow self transfers would lead to wastage of gas. Not sure if this is leaking any security risk.
Adding this would make the contract more robust.
And what about the short address check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants