Skip to content

Update h2 version for core-java-lang-oop-modifiers #13786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehsansasanian wants to merge 1 commit into from
Closed

Update h2 version for core-java-lang-oop-modifiers #13786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core-java-modules/core-java-lang-oop-modifiers/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</dependencies>

<properties>
<h2.version>1.4.197</h2.version> <!-- needs to be specified as it fails with parent's 1.4.200 -->
<h2.version>2.1.214</h2.version> <!-- needs to be specified as it fails with parent's 1.4.200 -->

@anastasiosioannidis anastasiosioannidis May 8, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the comment

@ehsansasanian ehsansasanian May 8, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do it.

</properties>

</project>
5 changes: 3 additions & 2 deletions ...oop-modifiers/src/test/java/com/baeldung/publicmodifier/PublicAccessModifierUnitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.baeldung.publicmodifier;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestInstance;
import org.junit.jupiter.api.TestInstance.Lifecycle;
Expand Down Expand Up @@ -64,9 +65,9 @@ public void whenParsingStringOne_parseIntReturns1() {
@Test
public void whenConnectingToH2_connectionInstanceIsReturned() throws SQLException {

final String url = "jdbc:h2:~/test";
final String url = "jdbc:h2:mem:test";

@anastasiosioannidis anastasiosioannidis May 8, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use the filesystem db, not the in-memory one.

@ehsansasanian ehsansasanian May 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already done in the new PR. #13976
Closing this PR

Connection conn = DriverManager.getConnection(url, "sa", "");
assertNotNull(conn);
Assertions.assertNotNull(conn);
}

@Test
Expand Down