You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've also got some manual tests for browser-related stuff. I'm not sure if you've been running those too but it looks like the browserify test is failing due to commit b3fd2b9 by @mprobst.
Activity
evanw commentedon May 16, 2015
I'd like to but the tests aren't passing due to the new changes coming in. I now see four failing tests. @julien-f?
julien-f commentedon May 16, 2015
Unfortunately I don’t have access to a computer this weekend, if you need me it will have to wait Monday.
I suspect #47 or #58.
julien-f commentedon May 16, 2015
We should set up CI to avoid that in the future (will probably set up Travis CI on Monday if you agree).
pspeter3 commentedon May 16, 2015
Pull request #47 is the cause for most of the test failures. Removing it only causes one to fail. I'm investigating more now
pspeter3 commentedon May 16, 2015
I added a pull request to pass the tests and will follow up with a test for #36
pspeter3 commentedon May 16, 2015
And now restored the behavior of #47
pspeter3 commentedon May 26, 2015
Now that the pull request is closed, can we push a new version?
evanw commentedon May 27, 2015
I've also got some manual tests for browser-related stuff. I'm not sure if you've been running those too but it looks like the browserify test is failing due to commit b3fd2b9 by @mprobst.
mprobst commentedon May 27, 2015
@evanw any more details on how it fails?
npm testsucceeds for me, but openingindex.htmldoesn't. How do you run the test?evanw commentedon May 28, 2015
Sorry, that isn't obvious. Added instructions to the readme: https://github.com/evanw/node-source-map-support/blob/master/README.md#tests. They have to run over the HTTP protocol because the file protocol is hopelessly broken.
evanw commentedon May 29, 2015
Just published as version 0.3.0.
pspeter3 commentedon May 29, 2015
The new version seems to no longer work in my code base for reading file maps
evanw commentedon May 30, 2015
@pspeter3 I just merged your pull request and published 0.3.1. Does that fix your issue?