You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Hyper-optimized Telemetry: Two unit tests are not following specifications in instructions for encoding #1795
On the Hyper-optimized Telemetry exercise, the instructions specify a table of ranges and target types for determining which type should be used when converting a long to the smallest integral type. Of particular interest in this issue is the range 0 - 65535 which should be represented with a ushort:
However, two unit tests are not following this specification. First one is ToBuffer_upper_short:
Since the supplied value 32767 is between 0 and 65353, this should be an unsigned short. Specifically 0x2, 0xff, 0x7f.
The second unit tests not following the instructions is ToBuffer_Zero. It has the exact same problem, expecting 0 to be a signed short, while the instructions specify that it should be unsigned.
changed the title [-]Hyper-optimized Telemetry: Two unit tests are not following specifications in instructions[/-][+]Hyper-optimized Telemetry: Two unit tests are not following specifications in instructions for encoding[/+]on Oct 29, 2021
Activity
[-]Hyper-optimized Telemetry: Two unit tests are not following specifications in instructions[/-][+]Hyper-optimized Telemetry: Two unit tests are not following specifications in instructions for encoding[/+]