Skip to content

International Calling Connoisseur - Tests should check for correct handling of duplicate Add(). #1845

Open

Description

@purringk

Add() throws if the key is already in the dictionary. I saw a bunch of passing solutions that don't check for the key before calling Add().

In general, there's lots of ways for dictionaries to throw exceptions when you do naive-but-seemingly-reasonable things, and the "Intro-to-Dictionaries" text might want to call out the common ways to go wrong.

Example test:

var countryCodes = DialingCodes.AddCountryToExistingDictionary(DialingCodes.GetExistingDictionary(), 91, "India");
Assert.Equal("India", countryCodes[91]);

Activity

  1. ErikSchierboom commented on Dec 3, 2021

    @ErikSchierboom
    Member

    I appreciate the suggestion. While you are correct in noting that Add would throw, having the tests verify this would mean that students would have to know about exceptions, which they'll only learn later on as that requires a fair bit more knowledge. As an alternative, I'd be happy to have this mentioned in the concepts about.md document. Would you be willing to submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions